Open
Conversation
485f592 to
89fa481
Compare
a3ff8bc to
9cbe119
Compare
00fca85 to
f91170e
Compare
Many libraries depend on the Jackson project (com.fasterxml.jackson) and Cheshire for processing JSON payloads. REMS has a direct dependency to jackson-datatype-joda which appears to have conflicted with other transitive dependencies - dropping references to Cheshire and allowing Leiningen to manage it's version, and updating the libraries that depend on it resulted in a bunch of exceptions tracing to Cheshire and com.fasterxml.jackson.core. Updating jackson-datatype-joda resolved the issue. Additionally, compojure-api appears to have dropped Cheshire in the commit metosin/compojure-api@1d92145 so we don't need the exclude clause for that lib anyway
…s to their organizations
…rm those tests that don't need the bindings
…he parent is the item being currently edited Also, add tests
b2f1206 to
b22551c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for author
Rebased onto #3440
Fix: #3412
Reviewability
Backwards compatibility
Documentation
Testing
Todo