Skip to content

Upgrade pindakaas -> 0.5.0 (+ re-enable BVA option for cadical)#869

Merged
hbierlee merged 7 commits intomasterfrom
fix/re-enable-bva
Apr 20, 2026
Merged

Upgrade pindakaas -> 0.5.0 (+ re-enable BVA option for cadical)#869
hbierlee merged 7 commits intomasterfrom
fix/re-enable-bva

Conversation

@hbierlee
Copy link
Copy Markdown
Contributor

Previously, enabling BVA resulted in a solver crash for cadical 3, so we disabled it. I'm enabling it to find the bug, it's not yet showing up locally.

@hbierlee
Copy link
Copy Markdown
Contributor Author

Awaiting pindakaashq/pindakaas#196

@hbierlee hbierlee added the blocked Pull request blocked by another pull request/issue. label Apr 16, 2026
@hbierlee hbierlee marked this pull request as ready for review April 17, 2026 07:40
@hbierlee hbierlee changed the title Re-enable BVA for Pindakaas/cadical Upgrade pindakaas -> 0.5.0 (+ re-enable BVA option for cadical) Apr 17, 2026
@hbierlee hbierlee removed the blocked Pull request blocked by another pull request/issue. label Apr 17, 2026
@hbierlee hbierlee requested a review from OrestisLomis April 20, 2026 11:44
@hbierlee
Copy link
Copy Markdown
Contributor Author

Summarizing, so before BVA (the factor option) had to be disabled for incremental solving to be correct due to a bug in how we used Cadical. In pindakaas 0.5, this bug is resolved, so we can re-enable the option. However, that means we have to bump the bound as well (otherwise we risk users running pindakaas 0.4 with the current cpmpy code which enabled that option).

Copy link
Copy Markdown
Contributor

@OrestisLomis OrestisLomis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to bump the version of pdk in this case

@hbierlee hbierlee merged commit 9ac4e8e into master Apr 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants