[FFS-4381] switch to an autogenerated swagger approach#73
Open
iannorriswork wants to merge 2 commits into
Open
[FFS-4381] switch to an autogenerated swagger approach#73iannorriswork wants to merge 2 commits into
iannorriswork wants to merge 2 commits into
Conversation
tdooner
approved these changes
May 14, 2026
tdooner
left a comment
There was a problem hiding this comment.
Seems legit but, oh man, what is going on with all that stubbing in rails_helper.rb?
| def inject_into_connection_string(conninfo); conninfo; end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Huh what, is there really no better way to stub out whatever AWS is necessary for (publishing the swagger file?) than this? Can we just disable the AWS related thing in test?
Contributor
Author
There was a problem hiding this comment.
yeah, that was the AI fighting against some defaults i need to fix...i'll yank that out and go fix that seperately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Description
This is a PR trying to move away from handcrafted swagger towards something that actually lives in the code.
Submitter Checklist
Reviewer Checklist
api-spec/and follows the organization's standards.Evidence of Testing