[Option Appraisal Module] [Package 1: Measures] Split 0: Move old measures to _legacy module#1274
Open
[Option Appraisal Module] [Package 1: Measures] Split 0: Move old measures to _legacy module#1274
Conversation
spjuhel
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs preps the field for the reworks of the Measure / MeasureSet classes.
Because the design completely changes, tests and code using the legacy code will fail.
To avoid that while gradually pushing the new code and before the new option appraisal module is fully ready, this PR moves the old code from
measuresto_legacy_measuresmodule, and import from there.PR Author Checklist
develop)PR Reviewer Checklist