Fix non-ASCII filename corruption in IPA ZIP entries#146
Open
ibrahimqatar wants to merge 1 commit intoCLARATION:mainfrom
Open
Fix non-ASCII filename corruption in IPA ZIP entries#146ibrahimqatar wants to merge 1 commit intoCLARATION:mainfrom
ibrahimqatar wants to merge 1 commit intoCLARATION:mainfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes filename corruption for non-ASCII files inside IPA archives during extract/repack.
Previously, ZIP entry names were trusted as decoded by default, which could corrupt filenames containing characters outside plain English when the archive’s UTF-8 metadata was missing or inconsistent. This caused bundled files such as media assets to appear with broken names after signing.
This change updates crates/plume_utils/src/package.rs to:
• decode ZIP entry names more safely from raw entry bytes
• avoid relying on default archive extraction for problematic filenames
• preserve corrected names during manual extraction
• repack the IPA with normalized Unicode-safe entry names
This fixes issues affecting Arabic, Turkish, and other non-ASCII filenames.
Fix provided with assistance from ChatGPT.