Skip to content

Fix/cjs build and publish fields#22

Merged
y-aithnini merged 2 commits intodevelopfrom
fix/cjs-build-and-publish-fields
Apr 7, 2026
Merged

Fix/cjs build and publish fields#22
y-aithnini merged 2 commits intodevelopfrom
fix/cjs-build-and-publish-fields

Conversation

@y-aithnini
Copy link
Copy Markdown
Contributor

Summary

  • What does this PR change?

Why

  • Why is this change needed?

Checklist

  • Added/updated tests (if behavior changed)
  • npm run lint passes
  • npm run typecheck passes
  • npm test passes
  • npm run build passes
  • Added a changeset (npx changeset) if this affects consumers

Notes

  • Anything reviewers should pay attention to?

The package was shipping ESM output without 'type: module' and without
.js extensions on internal imports — making it unloadable in Node.js.

- tsconfig.build.json: module=CommonJS, moduleResolution=Node10
- package.json: added exports field with require/default conditions
@y-aithnini y-aithnini requested a review from a team as a code owner April 7, 2026 13:02
Copilot AI review requested due to automatic review settings April 7, 2026 13:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the published package’s CommonJS compatibility by adjusting the build output module format and tightening the package entrypoints so consumers can load the library reliably.

Changes:

  • Updated tsconfig.build.json to emit CommonJS output for dist/.
  • Added a root exports map to package.json for the published entrypoint.
  • Added a changeset describing the packaging fix.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tsconfig.build.json Forces build output to CommonJS with Node-style resolution for dist/.
package.json Adds exports map (and updates version in this PR).
package-lock.json Updates lockfile version metadata to match the manual version bump.
.changeset/fix-cjs-build.md Documents the consumer-facing packaging fix as a patch changeset.

@y-aithnini y-aithnini merged commit 54c463d into develop Apr 7, 2026
5 checks passed
Zaiidmo added a commit that referenced this pull request Apr 7, 2026
* ops: UPDATED publish workflow and dependabot PR limits

* ops (ci): standardize publish validation and dependabot across all packages

- Replace git tag --list strategy with package.json-driven tag validation
  in all 16 publish workflows; use git rev-parse to verify the exact tag
  exists rather than guessing the latest repo-wide tag
- Update error guidance to reflect feat/** → develop → master flow
- Standardize dependabot to npm-only, grouped, monthly cadence across
  all 16 packages; remove github-actions ecosystem updates
- Add missing dependabot.yml to AuthKit-UI, ChartKit-UI, HealthKit,
  HooksKit, paymentkit, StorageKit

* security: added CODEOWNER file for branches security

* ops: updated relese check workflow#

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters (#1)

* Feature/compt 56 cache module service (#2)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* Feature/compt 57 cacheable cacheevict decorators (#3)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* feat(COMPT-57): add @Cacheable and @CacheEvict decorators with key interpolation

* Feature/compt 58 test suite (#4)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* feat(COMPT-57): add @Cacheable and @CacheEvict decorators with key interpolation

* test(COMPT-58): add full test suite with 95%+ coverage across all adapters, service, and decorators

* fix(lint): fix import/order and no-require-imports violations in spec files

* docs(COMPT-59): add README, update peer deps, create v0.1.0 changeset (#5)

* docs(COMPT-59): add README, update peer deps, create v0.1.0 changeset

* style: fix Prettier formatting across all files

* improvement: replace KEYS with SCAN, fix @Cacheable null-return bug, clean up index exports (#6)

* ci: update release check workflow

* fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/ (#8)

* ops: updated release check jobs ]

* install dep

* Fix/sonar test inclusions (#10)

* fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/

* chore: set version to 0.0.1 for initial publish

* Fix/sonar test inclusions (#12)

* fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/

* Develop (#7)

* ops: UPDATED publish workflow and dependabot PR limits

* ops (ci): standardize publish validation and dependabot across all packages

- Replace git tag --list strategy with package.json-driven tag validation
  in all 16 publish workflows; use git rev-parse to verify the exact tag
  exists rather than guessing the latest repo-wide tag
- Update error guidance to reflect feat/** → develop → master flow
- Standardize dependabot to npm-only, grouped, monthly cadence across
  all 16 packages; remove github-actions ecosystem updates
- Add missing dependabot.yml to AuthKit-UI, ChartKit-UI, HealthKit,
  HooksKit, paymentkit, StorageKit

* security: added CODEOWNER file for branches security

* ops: updated relese check workflow#

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters (#1)

* Feature/compt 56 cache module service (#2)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* Feature/compt 57 cacheable cacheevict decorators (#3)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* feat(COMPT-57): add @Cacheable and @CacheEvict decorators with key interpolation

* Feature/compt 58 test suite (#4)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* feat(COMPT-57): add @Cacheable and @CacheEvict decorators with key interpolation

* test(COMPT-58): add full test suite with 95%+ coverage across all adapters, service, and decorators

* fix(lint): fix import/order and no-require-imports violations in spec files

* docs(COMPT-59): add README, update peer deps, create v0.1.0 changeset (#5)

* docs(COMPT-59): add README, update peer deps, create v0.1.0 changeset

* style: fix Prettier formatting across all files

* improvement: replace KEYS with SCAN, fix @Cacheable null-return bug, clean up index exports (#6)

* ci: update release check workflow

* fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/ (#8)

* ops: updated release check jobs ]

---------

Co-authored-by: Zaiidmo <zaiidmoumnii@gmail.com>

* chore: set version to 0.0.1 for initial publish

---------

Co-authored-by: Zaiidmo <zaiidmoumnii@gmail.com>

* Fix/sonar test inclusions (#14)

* fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/

* Develop (#7)

* ops: UPDATED publish workflow and dependabot PR limits

* ops (ci): standardize publish validation and dependabot across all packages

- Replace git tag --list strategy with package.json-driven tag validation
  in all 16 publish workflows; use git rev-parse to verify the exact tag
  exists rather than guessing the latest repo-wide tag
- Update error guidance to reflect feat/** → develop → master flow
- Standardize dependabot to npm-only, grouped, monthly cadence across
  all 16 packages; remove github-actions ecosystem updates
- Add missing dependabot.yml to AuthKit-UI, ChartKit-UI, HealthKit,
  HooksKit, paymentkit, StorageKit

* security: added CODEOWNER file for branches security

* ops: updated relese check workflow#

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters (#1)

* Feature/compt 56 cache module service (#2)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* Feature/compt 57 cacheable cacheevict decorators (#3)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* feat(COMPT-57): add @Cacheable and @CacheEvict decorators with key interpolation

* Feature/compt 58 test suite (#4)

* feat(COMPT-55): add ICacheStore port and Redis/InMemory adapters

* feat(COMPT-56): add CacheModule, CacheService, and DI tokens

* style: fix Prettier formatting across all files

* style: fix Prettier formatting after develop merge

* fix(lint): fix import order and replace any types with proper NestJS types

* feat(COMPT-57): add @Cacheable and @CacheEvict decorators with key interpolation

* test(COMPT-58): add full test suite with 95%+ coverage across all adapters, service, and decorators

* fix(lint): fix import/order and no-require-imports violations in spec files

* docs(COMPT-59): add README, update peer deps, create v0.1.0 changeset (#5)

* docs(COMPT-59): add README, update peer deps, create v0.1.0 changeset

* style: fix Prettier formatting across all files

* improvement: replace KEYS with SCAN, fix @Cacheable null-return bug, clean up index exports (#6)

* ci: update release check workflow

* fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/ (#8)

* ops: updated release check jobs ]

---------

Co-authored-by: Zaiidmo <zaiidmoumnii@gmail.com>

* chore: set version to 0.0.1 for initial publish

---------

Co-authored-by: Zaiidmo <zaiidmoumnii@gmail.com>

* Fix/align version 1.0.0 (#17)

* chore: align version to 1.0.0 to match master

* chore: revert version to 0.0.1 as required

* fix(chore): reverted versions tags and fixed merge conflits

* 0.0.1

* chore: dump version 1

* fix: switch build to CommonJS and add exports field to package.json (#20)

The package was shipping ESM output without 'type: module' and without
.js extensions on internal imports — making it unloadable in Node.js.

- tsconfig.build.json: module=CommonJS, moduleResolution=Node10
- package.json: added exports field with require/default conditions

* Fix/cjs build and publish fields (#22)

* fix: switch build to CommonJS and add exports field to package.json

The package was shipping ESM output without 'type: module' and without
.js extensions on internal imports — making it unloadable in Node.js.

- tsconfig.build.json: module=CommonJS, moduleResolution=Node10
- package.json: added exports field with require/default conditions

* chore: bump version to 0.0.2

---------

Co-authored-by: Zaiidmo <zaiidmoumnii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants