Skip to content

Fix/sonar test inclusions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
y-aithnini merged 5 commits into from
Apr 7, 2026
Merged

Fix/sonar test inclusions #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b4ab8c
fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/
y-aithnini Apr 6, 2026
120a884
Develop (#7)
y-aithnini Apr 7, 2026
8e2ce04
chore: set version to 0.0.1 for initial publish
y-aithnini Apr 7, 2026
97d1f7a
chore: merge develop into fix/sonar-test-inclusions, resolve workflow…
y-aithnini Apr 7, 2026
cdc7289
chore: merge master into fix/sonar-test-inclusions, resolve workflow …
y-aithnini Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ jobs:
-Dsonar.organization=${{ env.SONAR_ORGANIZATION }}
-Dsonar.projectKey=${{ env.SONAR_PROJECT_KEY }}
-Dsonar.sources=src
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With -Dsonar.sources=src and no sonar.tests path configured, files under test/ (e.g. test/smoke.test.ts) likely won’t be scanned/classified as tests, even though sonar.test.inclusions includes **/*.test.ts. If the intent is to include both colocated src/**/*.spec.ts and test/**/*.test.ts, set sonar.tests to include both src and test (and keep sonar.sources=src).

Suggested change
-Dsonar.sources=src
-Dsonar.sources=src
-Dsonar.tests=src,test

Copilot uses AI. Check for mistakes.
-Dsonar.tests=test
-Dsonar.test.inclusions=**/*.spec.ts,**/*.test.ts
-Dsonar.exclusions=**/node_modules/**,**/dist/**,**/coverage/**,**/*.d.ts
-Dsonar.coverage.exclusions=**/*.spec.ts,**/*.test.ts,**/index.ts
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ciscode/cachekit",
"version": "1.0.0",
"version": "0.0.1",
"description": "CacheKit backend module for reusable caching utilities and integrations.",
Comment on lines 2 to 4
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version is being downgraded from 1.0.0 to 0.0.1. If 1.0.0 was ever published (or tagged), publishing 0.0.1 will be treated as an older version and consumers won’t receive updates; it also bypasses the repo’s Changesets-based versioning flow. Consider reverting this change and managing version bumps via a changeset instead (or confirm the intended initial version and update release process accordingly).

Copilot uses AI. Check for mistakes.
"author": "CisCode",
"publishConfig": {
Expand Down
Loading