Skip to content

Fix/sonar test inclusions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
y-aithnini merged 3 commits into from
Apr 7, 2026
+1 −2
Merged

Fix/sonar test inclusions #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b4ab8c
fix(ci): fix SonarCloud coverage — use src/**/*.spec.ts instead of test/
y-aithnini Apr 6, 2026
8e2ce04
chore: set version to 0.0.1 for initial publish
y-aithnini Apr 7, 2026
97d1f7a
chore: merge develop into fix/sonar-test-inclusions, resolve workflow…
y-aithnini Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ jobs:
-Dsonar.organization=${{ env.SONAR_ORGANIZATION }}
-Dsonar.projectKey=${{ env.SONAR_PROJECT_KEY }}
-Dsonar.sources=src
-Dsonar.tests=test
-Dsonar.test.inclusions=**/*.spec.ts,**/*.test.ts
-Dsonar.exclusions=**/node_modules/**,**/dist/**,**/coverage/**,**/*.d.ts
-Dsonar.coverage.exclusions=**/*.spec.ts,**/*.test.ts,**/index.ts
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ciscode/cachekit",
"version": "1.0.0",
"version": "0.0.1",
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version is being downgraded from 1.0.0 to 0.0.1. This will break publishing workflows (npm won’t accept a lower version than the latest published) and it also makes the repo inconsistent with the existing package-lock.json (which still declares version 1.0.0). If the goal is to align versions, update package.json to the intended current version and regenerate package-lock.json accordingly; otherwise revert this change and let Changesets manage version bumps.

Suggested change
"version": "0.0.1",
"version": "1.0.0",

Copilot uses AI. Check for mistakes.
"description": "CacheKit backend module for reusable caching utilities and integrations.",
"author": "CisCode",
"publishConfig": {
Expand Down
Loading