Conversation
nicolossus
left a comment
There was a problem hiding this comment.
Thanks!
An earlier PR bumped the neuroconv version to >=0.5.0. However, this seems to have introduced the error ImportError: cannot import name 'add_recording' from 'neuroconv.tools.spikeinterface' in expipe_plugin_cinpla/scripts/process.py.
The error is raised when the display_browser function is called, so we need to handle it to enable spike sorting. The now deprecated add_recording function is used to add "lfp" and "processed" groups to the NWB file.
Do you want to pin neuroconv to an earlier version or should we update expipe_plugin_cinpla to the new function call? (I think this is the correct new one https://github.com/catalystneuro/neuroconv/blob/main/src/neuroconv/tools/spikeinterface/spikeinterface.py#L36)
Make stricter dependency for hdmf and add additional requirements