Additions/improvements/fixes targetting version 1.0.0-alpha3#4
Open
Additions/improvements/fixes targetting version 1.0.0-alpha3#4
Conversation
(also work around or silence certain false positives)
...get_non_falsy_msg_related_components():
* rename it to get_dict_with_non_falsy_pattern_and_args()
* parameter *args_output_key* gains a default value ("args"`) and
becomes a keyword-only one
* add parameter *pattern_output_key* (with default value "pattern",
also keyword-only one)
zuo
force-pushed
the
zuo/changes-for-v1.0.0-alpha3
branch
from
7c54517 to
f1beaf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtendedMessage'sformat_message()toget_message_value().ExtendedMessage'sget_non_falsy_msg_related_components()toget_dict_with_non_falsy_pattern_and_args()ExtendedMessage'sget_dict_with_non_falsy_pattern_and_args()(exget_non_falsy_msg_related_components()) by making the parameterargs_output_keykeyword-only and adding to it a default value ("args"); as well as by adding a new parameter:pattern_output_key, also keyword-only one and with a default value ("pattern").ExtendedMessage-subclassing-related behavioral detail, by adding optional resolving of callable values also to the__str__()anditer_str_parts()methods.ExtendedMessage.get_message_value(): implement per-instance text message caching (so that the message needs to be formatted only once).py.typedmarker file, and fix/improve several type hints (+ adjust some other static-typing-related code details).dev-*.bashscripts.