made nanoprintf context static to reduce call overhead and size#709
Open
ZERICO2005 wants to merge 1 commit intomasterfrom
Open
made nanoprintf context static to reduce call overhead and size#709ZERICO2005 wants to merge 1 commit intomasterfrom
ZERICO2005 wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made
npf_cnt_putc_ctx_t pc_cntstatic innpf_vpprintf, moving them off of the stack frame. This changes frameset from 145 to 138. Call overhead was also reduced sinceNPF_PUTC(VAL)now calls a 1 argument function instead of a 2 argument function. Overall this saves 242 bytes with Clang 17 codegen.This optimization can be controlled via the
NANOPRINTF_STATIC_GLOBALSmacro I have added