Add DISCONNECT structure event for app connection loss#26
Merged
stefanrammo merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Adds DISCONNECT (3) to studio.api.structure to distinguish app going offline from child node removal (REMOVE): - DISCONNECT (3) fires at root level when an app goes offline - REMOVE (0) fires at node level when a child is removed - RECONNECT (2) fires at root level when a disconnected app returns Also populates connectionLocalApps for the primary connection in proxy mode. Previously it was only populated in direct mode, so the primary app never fired DISCONNECT or RECONNECT when its connection dropped in proxy mode. CDP-6069
Karmo7
approved these changes
Apr 8, 2026
| (e.g. components or operators added to a running application): | ||
|
|
||
| - ``studio.api.structure.ADD`` (1) — A child node was added | ||
| - ``studio.api.structure.REMOVE`` (0) — A child node was removed |
There was a problem hiding this comment.
If you called subscribeToStructure on a deeped node (not root node) then shouldn't those nodes also report DISCONNECT and RECONNECT? I mean add/remove should refer to when something in CDP node tree actually changes, e.g. a CDPOperator is added/removed from a component.
Collaborator
Author
There was a problem hiding this comment.
REMOVE now only fires for tree node changes, not app lifecycle. DISCONNECT and RECONNECT currently only fire when subscribed on the system node, not on individual app nodes. I could do a follow up to add it for deeper nodes.
nuubik
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DISCONNECT (3) to studio.api.structure to distinguish app going offline from child node removal (REMOVE):
Also populates connectionLocalApps for the primary connection in proxy mode. Previously it was only populated in direct mode, so the primary app never fired DISCONNECT or RECONNECT when its connection dropped in proxy mode.
CDP-6069