Clarify/standardize renewal model equations across docs#773
Merged
cdc-mitzimorris merged 54 commits intomainfrom Apr 9, 2026
Merged
Clarify/standardize renewal model equations across docs#773cdc-mitzimorris merged 54 commits intomainfrom
cdc-mitzimorris merged 54 commits intomainfrom
Conversation
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
reviewed
Apr 6, 2026
damonbayer
requested changes
Apr 6, 2026
Collaborator
damonbayer
left a comment
There was a problem hiding this comment.
Thanks @cdc-mitzimorris! I think we need to clarify "initial" vs "time 0". Other changes are more optional.
Co-authored-by: Damon Bayer <xum8@cdc.gov>
Collaborator
Author
|
@damonbayer I have made all requested changes:
|
damonbayer
reviewed
Apr 8, 2026
damonbayer
reviewed
Apr 8, 2026
damonbayer
reviewed
Apr 8, 2026
| We use `innovation_sd = 0.01` (smaller than the 0.05 used for Random Walk and AR(1) above). | ||
|
|
||
| ```{python} | ||
| # | label: dar1-sample |
Collaborator
There was a problem hiding this comment.
Add a caption to this figure?
damonbayer
reviewed
Apr 8, 2026
docs/tutorials/latent_infections.qmd
Outdated
| ```{python} | ||
| # | label: fig-hyperparam-effect | ||
| # | fig-cap: Effect of DifferencedAR1 hyperparameters on prior Rt distribution. Lower autoreg and innovation_sd (left) produce a tighter envelope; higher values (right) allow wider drift. All start at Rt = 1.22. | ||
| # | fig-cap: Effect of DifferencedAR1 hyperparameters on prior Rt distribution. Lower autoreg and innovation_sd (left) produce a tighter envelope; higher values (right) allow wider drift. All start at Rt = 1.65. |
Collaborator
There was a problem hiding this comment.
Use $\mathcal{R}(t)$ instead of Rt
Collaborator
There was a problem hiding this comment.
You could actually say
damonbayer
reviewed
Apr 8, 2026
damonbayer
approved these changes
Apr 8, 2026
Collaborator
damonbayer
left a comment
There was a problem hiding this comment.
Thanks @cdc-mitzimorris! I requested a few more changes, but you can merge when you feel it is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses all comments in issue #768 and further improves the discussion of the renewal models supported by PyRenew.