fix: resolve exponential timer drain in wake-up challenges by adding …#902
Open
vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
Open
fix: resolve exponential timer drain in wake-up challenges by adding …#902vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
vibhutomer wants to merge 1 commit intoCCExtractor:mainfrom
Conversation
…loop cancellation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical concurrency bug in
alarm_challenge_controller.dartwhere multiple asynchronous_startTimer()loops could run simultaneously. Previously, callingrestartTimer()spawned a newforloop without terminating the old one, leading to an exponential drain on the progress bar and causing users to unfairly fail wake-up challenges.Proposed Changes
_timerSessionIdstate variable to track the active timer lifecycle.restartTimer()to increment the session ID upon invocation.(if (currentSessionId != _timerSessionId) break;)inside the_startTimer()async loop. This acts as a cancellation token, instantly killing orphaned loops and ensuring only a single asynchronous loop modifiesprogress.valueat any given time.Fixes #901
Screenshots
(Not applicable - backend logic and concurrency fix)
Checklist