Open
Conversation
edited explainations
Member
|
@saeedCodium Hello, could you please remove |
Author
|
Hello Krub , Ok
…On Fri, Jun 4, 2021 at 4:16 PM Preeti Yuankrathok ***@***.***> wrote:
@saeedCodium <https://github.com/saeedCodium> Hello, could you please
remove .DS_Store files krubb?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APIJEH3JG34PGCHKL77LUNTTRCKVTANCNFSM456RTLFA>
.
--
Best Regards
Saeed Rahmatolahi
|
auto-merge was automatically disabled
June 4, 2021 11:15
Head branch was pushed to by a user without write access
piyapan039285
requested changes
Jun 7, 2021
Contributor
piyapan039285
left a comment
piyapan039285
left a comment
There was a problem hiding this comment.
I think the content is good. Some sentences are too long to catch up. So I give you some sample how to break down into smaller topics.
| the easiest and fastest way to setting the constraints is using the AutoLayout part in the storyboard and xib files without need to set any constraints in the codes (some times you need to change the constraints run time and the size will set in the runtime as well so in that case you need to set the constraints in the storyboard or xib files and then drag that constraint to your code to change it run time) | ||
|
|
||
| ### passing the data | ||
| to pass the data do not use `Notification Center` or `User Defaults`, you can use call back functions and delegate protocols instead . if you are using delegate protocols remember to make your delegates `weak`to avoid memory leaks. in some callback functions you need to use `weak` for avoiding the memory leaks problem. make sure every view controller which dismissed the `deinit` function executes in that class after dismissing. you can make some protocol functions optional to avoid using those functions in the other classes that you may use. |
Contributor
There was a problem hiding this comment.
This one should break into small topics.
- Do not use
Notification CenterorUser Defaults. You can use call back functions and delegate protocols instead - If you are using delegate protocols remember to make your delegates
weakto avoid memory leaks. in some callback functions you need to useweakfor avoiding the memory leaks problem. - Make sure every view controller which dismissed the
deinitfunction executes in that class after dismissing. you can make some protocol functions optional to avoid using those functions in the other classes that you may use.
Author
There was a problem hiding this comment.
this part explains how to pass the data , it doesn't contains separate parts .
Contributor
There was a problem hiding this comment.
I agree with you. I just think that topic "pass the data" can be break down into smaller topics but it is ok to combine together.
Here is sample on apple documentation on how they break down topics:
some titles removed & some parts break into other parts
big parts broke up into small parts
Contributor
|
|
NorakGithub
requested changes
Jun 23, 2021
Contributor
NorakGithub
left a comment
NorakGithub
left a comment
There was a problem hiding this comment.
To be able to show your content in the compiled website you will need to
- Add
iossection in_config.yml > header_pages - Rename
iOStoiosdirectory - Create
README.mdin newly renamediosdirectory - Add below content in the newly created
README.md
---
title: iOS
has_sub_pages: true
permalink: ios
---
- Your MVC README should be in
Architecturesdirectory, since it's about application architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVC Design pattern explained . how to implement the MVC Design pattern correctly