test: drop duplicate top-level test files#151
Merged
Conversation
Squash-merge of #150 added the subdir copies without removing the top-level originals, leaving every test file present in two places. Removes the 50 stale top-level files and the duplicate prefork_apps/ directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of an artifact from how #150 was merged. The squash-merge of #150 (group tests into subdirs) recorded only the subdir additions, not the top-level deletions, so every test file ended up in two places at once:
tests/test_X.pyANDtests/<subdir>/test_X.py.Removes the 50 stale top-level
test_*.pyfiles plus the duplicatetests/prefork_apps/directory. Verified all 50 pairs were byte-identical before deletion.Pure deletion — 53 files / -9195 lines, no other changes.
Why this happened
#150 was stacked on #149's branch. When #150 was squash-merged, GitHub computed the squashed diff against the branch's pre-rename state rather than against post-#149 master, so the rename pairs collapsed to "add new path, leave old in place." The top-level files matched the merged tree on disk, so
git statusshowed clean — onlylsrevealed the duplication.Test plan
tests/test_X.py↔tests/<subdir>/test_X.pypairs are byte-identical.uv run python -m pytest tests/ --collect-only— 514 tests (unchanged).uv run python -m pytest tests/core/test_basic.py tests/worker/test_prefork.py tests/workflows/test_workflows_linear.py— 32 passed, 1 skipped (covers the prefork_apps import path under the new layout).