chore(mixins): use inspect.iscoroutinefunction in decorators#107
Merged
Conversation
`import asyncio` is reserved for async_support/, app.py, and contrib/fastapi.py per the project's async-separation boundary. `inspect.iscoroutinefunction` has identical semantics for detecting `async def` functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py_src/taskito/mixins/decorators.pywas the last file in the non-async, non-contrib core that importedasyncio— a violation of the project's async-separation boundary (which confinesimport asynciotoasync_support/,app.py, andcontrib/fastapi.py).import asyncio+asyncio.iscoroutinefunction(fn)withimport inspect+inspect.iscoroutinefunction(fn). Identical semantics for detectingasync deffunctions.After this change, the boundary is machine-checkable with a single grep:
```
$ grep -rn "import asyncio" py_src/taskito/ | grep -v -E "(async_support/|contrib/fastapi.py)"
(empty)
```
Test plan
uv run python -m pytest tests/python/ -v— 488 passed, 9 skipped (no regressions intest_async_*which exercise the_taskito_is_asyncflag set at this call site)uv run ruff check py_src/ tests/— cleanuv run mypy py_src/taskito/ --no-incremental— cleancargo check --workspace— cleangrep -rn "import asyncio" py_src/taskito/ | grep -v -E "(async_support/|contrib/fastapi\.py)"returns empty