refactor: enforce non-null constraints on consume_coupon fields#1805
Draft
purplesmoke05 wants to merge 1 commit intodev-26.6from
Draft
refactor: enforce non-null constraints on consume_coupon fields#1805purplesmoke05 wants to merge 1 commit intodev-26.6from
purplesmoke05 wants to merge 1 commit intodev-26.6from
Conversation
…pdate related tests
Coverage Report •
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Refactor indexed position aggregation to enforce token-type-specific query invariants in SQL, remove defensive assertions and broad tuple casts, and harden coupon consumption nullability.
✅ Related Issues
🔄 Changes
/Position/{account_address}indexed aggregation to build token-type-specific queries and merge them withUNION ALL.Nullable(...)andtype_coerce(...)where SQLAlchemy result typing needed explicit nullability/type hints.assertusage in aggregated position handling by making token cache presence guaranteed by the query shape.NOT NULLforconsume_coupon.amountandconsume_coupon.block_timestampvia migration and updated ORM typing accordingly.amountandblock_timestampas non-null.consume_couponrows andNOT NULLenforcement.📌 Checklist