Make listing fields required and remove orphan executable contracts#1804
Merged
YoshihitoAso merged 3 commits intodev-26.6from Apr 3, 2026
Merged
Make listing fields required and remove orphan executable contracts#1804YoshihitoAso merged 3 commits intodev-26.6from
YoshihitoAso merged 3 commits intodev-26.6from
Conversation
YoshihitoAso
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
This pull request enforces non-null constraints on key columns in the
listingtable and audit columns (created,modified) across multiple tables, updates the SQLAlchemy models to reflect these constraints, and removes now-unnecessary runtime assertions.✅ Related Issues
🔄 Changes
Database schema and migration changes:
Added a migration (
4df7e2c1b8a3_v26_6_0_feature_1792.py) that backfillscreatedandmodifiedcolumns with the current timestamp where they are null, and alters these columns (as well aslisting.token_address,listing.is_public, andlisting.owner_address) to be non-nullable across all relevant tables. It also cleans up invalid data inlistingand related tables.Updated the
Listingmodel to maketoken_address,is_public, andowner_addressnon-nullable, and removed the assertion thatcreatedis not None in itsjsonmethod.Updated the
createdandmodifiedcolumns inBase,Company, andNotificationmodels to be non-nullable.API and codebase cleanup:
token_address,is_public,owner_address, andcreatedin several API endpoints, as these are now enforced at the schema level.📌 Checklist