FILT: Add the HierarchicalSmooth triangle mesh smoothing algorithm#1551
Merged
imikejackson merged 2 commits intoBlueQuartzSoftware:developfrom Mar 3, 2026
Merged
Conversation
e9290a5 to
4d77837
Compare
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
- Add const-correctness to function parameters throughout the algorithm - Remove redundant EdgePairEqual struct (std::pair already has operator==) - Change fastChainLinkSort windingDict to std::map for cross-platform determinism - Remove unused Triangulation members (m_Mesh, m_SubTri, m_EdgeList) and accessors - Use dense Eigen matrices for vertex data instead of sparse (2.7x perf improvement) - Add throttled messaging and cancel checks in processing loop - Use std::move for Eigen matrix transfer to avoid copies - Switch boundary dict to OrderedEdgeDict (std::map) for reproducible results - Update test to use exemplar-based comparison with correct error threshold Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4d77837 to
c9610e4
Compare
nyoungbq
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off the code from https://github.com/siddharth-maddali/HierarchicalSmooth/tree/master.
This was asked for back in 2018. @siddharth-maddali