BL-16038 Prioritize sign language for Bloom Library QR code#7782
Open
BL-16038 Prioritize sign language for Bloom Library QR code#7782
Conversation
https://issues.bloomlibrary.org/youtrack/issue/BL-16038/QR-Code-for-Sign-Language Use the same sign-language-first Bloom Library language selection for QR code generation that the collection banner already uses. Summary: - add shared collection settings helpers for the Bloom Library primary language tag and name - use that shared logic in the collection banner book-count lookup and QR code generation - add regression tests for collections with and without sign language Tests: - dotnet test src/BloomTests/BloomTests.csproj --filter "PrimaryLanguage_WithoutSignLanguage_UsesLanguage1|PrimaryLanguage_WithSignLanguage_UsesSignLanguage" --no-restore
Contributor
Author
|
GitHub Copilot submitted #7782 |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.bloomlibrary.org/youtrack/issue/BL-16038/QR-Code-for-Sign-Language
Use the same sign-language-first Bloom Library language selection for QR code generation that the collection banner already uses.
Summary:
Tests:
This change is