Skip to content

fix(makefile): align clean, lint and format-check with CI#187

Open
gmmcosta15 wants to merge 3 commits intodevfrom
bugfix/makefile
Open

fix(makefile): align clean, lint and format-check with CI#187
gmmcosta15 wants to merge 3 commits intodevfrom
bugfix/makefile

Conversation

@gmmcosta15
Copy link
Collaborator

Description

Select the type:

  • Feature
  • Bug fix
  • Code refactor
  • Documentation

format-check: removed explicit BlocksScreen tests path args that were overriding pyproject.toml's exclude = ["tests"];
added --config=pyproject.toml --target-version=py311 to match CI exactly.
lint: added --recursive=y and trailing slash so pylint scans the directory without requiring __init__.py, matching the CI invocation.
clean: separated directory and file deletion into two find calls with || true to suppress errors from already-deleted paths;
added .ruff_cache and .mypy_cache to the rm -rf line.

Motivation

make check was diverging from CI: format-check was failing on test files locally (because passing explicit paths bypasses ruff's exclude
config), while CI passed; lint was crashing with a parse error because pylint couldn't find __init__.py; and make clean left behind
pycache directories under some conditions. This aligns all three targets to run identically to the GitHub Actions workflow.

Tests

Verified locally:

  • make format-check — passes (66 files already formatted, tests excluded)
  • make lint — runs without parse errors, same pylint invocation as CI
  • make clean — removes all __pycache__, .pytest_cache, .ruff_cache, .mypy_cache

@gmmcosta15 gmmcosta15 requested a review from HugoCLSC March 3, 2026 16:16
@gmmcosta15 gmmcosta15 self-assigned this Mar 3, 2026
@gmmcosta15 gmmcosta15 added the enhancement New feature or request. label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants