fix(makefile): align clean, lint and format-check with CI#187
Open
gmmcosta15 wants to merge 3 commits intodevfrom
Open
fix(makefile): align clean, lint and format-check with CI#187gmmcosta15 wants to merge 3 commits intodevfrom
gmmcosta15 wants to merge 3 commits intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the type:
format-check: removed explicitBlocksScreen testspath args that were overridingpyproject.toml'sexclude = ["tests"];added
--config=pyproject.toml --target-version=py311to match CI exactly.lint: added--recursive=yand trailing slash so pylint scans the directory without requiring__init__.py, matching the CI invocation.clean: separated directory and file deletion into twofindcalls with|| trueto suppress errors from already-deleted paths;added
.ruff_cacheand.mypy_cacheto therm -rfline.Motivation
make checkwas diverging from CI:format-checkwas failing on test files locally (because passing explicit paths bypasses ruff's excludeconfig), while CI passed;
lintwas crashing with a parse error because pylint couldn't find__init__.py; andmake cleanleft behindpycache directories under some conditions. This aligns all three targets to run identically to the GitHub Actions workflow.
Tests
Verified locally:
make format-check— passes (66 files already formatted, tests excluded)make lint— runs without parse errors, same pylint invocation as CImake clean— removes all__pycache__,.pytest_cache,.ruff_cache,.mypy_cache