-
Notifications
You must be signed in to change notification settings - Fork 70
Update render-engine and adopt RedirectPage #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
34393ec
9806574
f4a7b32
439cdde
ba87d43
515247f
a1d6349
239befc
02fb86d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,17 +4,26 @@ version = "0.1.0" | |
| description = "Black Python Devs community website" | ||
| requires-python = ">=3.13" | ||
| dependencies = [ | ||
| "render-engine[cli]>=2026.3.4a2", | ||
| "render-engine-clean-urls", | ||
| "pyyaml", | ||
| "render-engine[cli]>=2026.5.2a1", | ||
| "render-engine-clean-urls==0.1.0", | ||
| "pyyaml==6.0.3", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Low Care Amount: Is pyyaml explicitly imported anywhere? If not, I'd probably not include it in the top-level packages. But if we are including it solve a CVE, then we could do
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is. IIRC we run deptry so all the items that are in the dependencies are directly called in the app. |
||
| "folium>=0.20.0", | ||
| "click", | ||
| "pycountry", | ||
| "click==8.3.1", | ||
| "pycountry==26.2.16", | ||
| "python-slugify>=8.0.4", | ||
|
|
||
| ] | ||
|
|
||
| [dependency-groups] | ||
| dev = ["pre-commit", "typer", "rich", "python-frontmatter", "pytest", "ruff"] | ||
| dev = [ | ||
| "pin-versions==2026.3.6", | ||
| "pre-commit==4.6.0", | ||
| "typer==0.25.1", | ||
| "rich==14.3.3", | ||
| "python-frontmatter==1.1.0", | ||
| "pytest==9.0.3", | ||
| "ruff==0.15.13", | ||
| ] | ||
|
|
||
| [tool.render-engine.cli] | ||
| module = "app" | ||
|
|
||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium Care Amount: I'm curious as to why we're pinning explicit versions. I mean I know that its definitely the most reproducible, but I feel like most of these could benefit from allowing patch versions to pick up vulnerability fixes in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit versions is just based on historical presedent as render-engine ran into parser errors because we didn't explicitly pin our versions. FMI: render-engine/render-engine-markdown#9 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes perfect sense. I do think a good medium path would still be adding constraints that aren't exact version pins, but that is a future consideration!