fix(ada): providing unsigned sweep support for WRW#8248
Draft
fix(ada): providing unsigned sweep support for WRW#8248
Conversation
6269f8c to
2321317
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-134
Description
Extends the ADA unsigned sweep (cold wallet recovery) flow to correctly handle token-holding wallets.
Two gaps existed in the unsigned sweep path:
parsedTx.outputs[0], so token transactions with 2 outputs were brokenChanges:
extractTokenTransfers()helper that convertsCardanoWasm.MultiAssetinto a flat '{ policyId, assetName, quantity }' array. Updated 'explainTransaction()' return type and output mapping to include 'tokenTransfers?' per output.recover()unsigned sweep path to map over all 'parsedTx.outputs' instead of hardcoding only 'outputs[0]', with 'tokenTransfers' passed through.tokenTransferspopulated inexplainTransaction().Issue Number
CSHLD-134
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Ran npx mocha test file