Skip to content

fix(teleport): restore ratio semantics to match backend config #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaubee merged 1 commit into from
Mar 1, 2026
Merged

fix(teleport): restore ratio semantics to match backend config #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions miniapps/teleport/src/App.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,10 +472,10 @@ describe('Teleport App', () => {
fireEvent.click(screen.getByTestId('target-button'))

await waitFor(() => {
expect(screen.getByText('1 BFT = 24.03846154 BFM')).toBeInTheDocument()
expect(screen.getByText('1 BFM = 0.0416 BFT')).toBeInTheDocument()
expect(screen.getByText('1 BFT = 0.0416 BFM')).toBeInTheDocument()
expect(screen.getByText('1 BFM = 24.03846154 BFT')).toBeInTheDocument()
expect(
screen.getAllByText((_, node) => node?.textContent?.includes('240384.61538462 BFM') ?? false)
screen.getAllByText((_, node) => node?.textContent?.includes('416 BFM') ?? false)
.length,
).toBeGreaterThan(0)
})
Expand Down
10 changes: 5 additions & 5 deletions miniapps/teleport/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ const formatRatioRate = (
if (!ratio) return '0';
const numerator = Number(ratio.numerator);
const denominator = Number(ratio.denominator);
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || numerator === 0) return '0';
return (denominator / numerator).toFixed(8).replace(/\.?0+$/, '');
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || denominator === 0) return '0';
return (numerator / denominator).toFixed(8).replace(/\.?0+$/, '');
};

const formatInverseRatioRate = (
Expand All @@ -275,8 +275,8 @@ const formatInverseRatioRate = (
if (!ratio) return '0';
const numerator = Number(ratio.numerator);
const denominator = Number(ratio.denominator);
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || denominator === 0) return '0';
return (numerator / denominator).toFixed(8).replace(/\.?0+$/, '');
if (!Number.isFinite(numerator) || !Number.isFinite(denominator) || numerator === 0) return '0';
return (denominator / numerator).toFixed(8).replace(/\.?0+$/, '');
};

export default function App() {
Expand Down Expand Up @@ -612,7 +612,7 @@ export default function App() {
if (!selectedAsset || !amount) return '0';
const amountNum = Number(amount);
if (!Number.isFinite(amountNum)) return '0';
const ratioNum = Number(selectedAsset.ratio.denominator) / Number(selectedAsset.ratio.numerator);
const ratioNum = Number(selectedAsset.ratio.numerator) / Number(selectedAsset.ratio.denominator);
if (!Number.isFinite(ratioNum)) return '0';
return (amountNum * ratioNum).toFixed(8).replace(/\.?0+$/, '');
}, [selectedAsset, amount]);
Expand Down