Skip to content

fix(teleport): clarify ratio semantics on confirm step#492

Merged
Gaubee merged 2 commits intomainfrom
fix/teleport-ratio-semantics
Mar 1, 2026
Merged

fix(teleport): clarify ratio semantics on confirm step#492
Gaubee merged 2 commits intomainfrom
fix/teleport-ratio-semantics

Conversation

@Gaubee
Copy link
Contributor

@Gaubee Gaubee commented Mar 1, 2026

Summary

  • replace ambiguous ratio display (e.g. 416:10000) with explicit copy 1 FROM = RATE TO
  • keep ratio/expected receive calculation guarded against invalid denominator
  • add regression test for the ratio semantics case (BFT -> BFM, 416/10000)

Validation

  • pnpm --filter @biochain/miniapp-teleport typecheck:run
  • pnpm --filter @biochain/miniapp-teleport test:run

@Gaubee Gaubee merged commit 1c2d873 into main Mar 1, 2026
5 checks passed
@Gaubee Gaubee deleted the fix/teleport-ratio-semantics branch March 1, 2026 01:55
@Gaubee Gaubee linked an issue Mar 3, 2026 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant