Open
Conversation
added cchs 2015-16 and 2017-18 survey cycles for ADL variables and associated functions
added in 2015-2016 and 2017-2018 master survey cycles into ADLs
Contributor
|
@caitlink12 Can you indicate what variables you added, modified, or deleted? I thought these were already previously part of the PR -- this PR started with your changes in the "temp" repo. @yulric Do you have suggestions for reviewing this commit with 100% diffs? |
Contributor
|
@caitlink12 just confirming these variables don't include the derived variables. That was previously submitted by you. Right? |
yulric
changed the base branch from
feature/v3.0.0-validation-infrastructure
to
adj-bmi
yulric
requested changes
Nov 10, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
There are inconsistencies with the suffixes used between the variables and variable details sheet. The variables sheet uses _m whereas the details sheet uses _i. Can you fix those?
fixed the name of incorrect survey variables used for 2017-2018 survey cycles
yulric
approved these changes
Nov 20, 2025
rafdoodle
reviewed
Feb 19, 2026
| ADL_01,ADL_01_cat2_NA::a,cat,"cchs2015_2016_p, cchs2017_2018_p, cchs2015_2016_m, cchs2017_2018_m","cchs2015_2016_p::ADL_005, cchs2017_2018_p::ADL_005, cchs2015_2016_m::ADL_005, cchs2017_2018_m::ADL_005",,cat,NA::a,2,not applicable,not applicable,N/A,6,not applicable,Help preparing meals,Needs help - preparing meals,,,,active,, | ||
| ADL_01,ADL_01_cat2_NA::b,cat,"cchs2015_2016_p, cchs2017_2018_p, cchs2015_2016_m, cchs2017_2018_m","cchs2015_2016_p::ADL_005, cchs2017_2018_p::ADL_005, cchs2015_2016_m::ADL_005, cchs2017_2018_m::ADL_005",,cat,NA::b,2,missing,missing,N/A,"[7,9]",don't know (7); refusal (8); not stated (9),Help preparing meals,Needs help - preparing meals,,,,active,, | ||
| ADL_01,ADL_01_cat2_NA::b,cat,"cchs2015_2016_p, cchs2017_2018_p, cchs2015_2016_m, cchs2017_2018_m","cchs2015_2016_p::ADL_005, cchs2017_2018_p::ADL_005, cchs2015_2016_m::ADL_005, cchs2017_2018_m::ADL_005",,cat,NA::b,2,missing,missing,N/A,else,else,Help preparing meals,Needs help - preparing meals,,,,active,, | ||
| ADL_01_A,ADL_01_A_cat4_1,cat,"cchs2015_2016_p, cchs2017_2018_p, cchs2015_2016_m, cchs2017_2018_m",[ADL_005],,cat,1,4,"Yes difficulty, need help","Yes difficulty, need help",N/A,3,"Yes difficulty, need help",Help preparing meals,Needs help - preparing meals,"For 2015 onwards, question was reword to 'Because of any physical condition, mental condition or health problem, do you have any difficulty with preparing meals?' If they needed help from another person, it is indicated in the answer categories (Yes need help or Yes no help). In the universe, respondents must said yes to ""Activities of daily living"" before answering this question, therefore the sample size is small.",,,active,, |
Collaborator
There was a problem hiding this comment.
What is the point of a separate 2015-2018 _A variable with 4 categories when those 4 categories can just be collapsed into usual 2 non _A categories (3-4 -> 1, 1-2 -> 2) as seen in lines 12-16?
rafdoodle
reviewed
Feb 19, 2026
| ADL_07,ADL_07_cat2_NA::a,cat,"cchs2001_p, cchs2003_p, cchs2005_p, cchs2001_m, cchs2003_m, cchs2005_m","cchs2001_p::RACA_6D, cchs2003_p::RACC_6D, cchs2005_p::RACE_6D, cchs2001_m::RACA_6D, cchs2003_m::RACC_6D, cchs2005_m::RACE_6D",ICES confirmed,cat,NA::a,2,not applicable,not applicable,N/A,6,not applicable,Help heavy household chores,Needs help - heavy household chores,,,,active,v3.0.0alpha, | ||
| ADL_07,ADL_07_cat2_NA::b,cat,"cchs2001_p, cchs2003_p, cchs2005_p, cchs2001_m, cchs2003_m, cchs2005_m","cchs2001_p::RACA_6D, cchs2003_p::RACC_6D, cchs2005_p::RACE_6D, cchs2001_m::RACA_6D, cchs2003_m::RACC_6D, cchs2005_m::RACE_6D",ICES confirmed,cat,NA::b,2,missing,missing,N/A,"[7,9]",don't know (7); refusal (8); not stated (9),Help heavy household chores,Needs help - heavy household chores,,,,active,v3.0.0alpha, | ||
| ADL_07,ADL_07_cat2_NA::b,cat,"cchs2001_p, cchs2003_p, cchs2005_p, cchs2001_m, cchs2003_m, cchs2005_m","cchs2001_p::RACA_6D, cchs2003_p::RACC_6D, cchs2005_p::RACE_6D, cchs2001_m::RACA_6D, cchs2003_m::RACC_6D, cchs2005_m::RACE_6D",ICES confirmed,cat,NA::b,2,missing,missing,N/A,else,else,Help heavy household chores,Needs help - heavy household chores,,,,active,v3.0.0alpha, | ||
| ADL_der,ADL_der_catN/A_Func::calculate_adl,cat,"cchs2001_p, cchs2003_p, cchs2005_p, cchs2007_2008_p, cchs2009_2010_p, cchs2010_p, cchs2011_2012_p, cchs2012_p, cchs2013_2014_p, cchs2014_p, cchs2015_2016_p, cchs2017_2018_p, cchs2001_m, cchs2003_m, cchs2005_m, cchs2007_2008_m, cchs2009_2010_m, cchs2009_m, cchs2010_m, cchs2011_2012_m, cchs2012_m, cchs2013_2014_m, cchs2015_2016_m, cchs2017_2018_m","DerivedVar::[ADL_01, ADL_02, ADL_03, ADL_04, ADL_05]",,N/A,Func::calculate_adl,N/A,N/A,N/A,N/A,N/A,N/A,Derived help tasks,Derived needs help with tasks,"Derived variable based on ADL_01, ADL_02, ADL_03, ADL_04, ADL_05",,,active,,No typeStart |
Collaborator
There was a problem hiding this comment.
Is it supposed to say Func::assess_adl in line 114??
rafdoodle
reviewed
Feb 19, 2026
| ADL_score_5,ADL_score_5_cat6_6,cat,"cchs2001_p, cchs2003_p, cchs2005_p, cchs2007_2008_p, cchs2009_2010_p, cchs2010_p, cchs2011_2012_p, cchs2012_p, cchs2013_2014_p, cchs2014_p, cchs2015_2016_p, cchs2017_2018_p, cchs2001_m, cchs2003_m, cchs2005_m, cchs2007_2008_m, cchs2009_2010_m, cchs2009_m, cchs2010_m, cchs2011_2012_m, cchs2012_m, cchs2013_2014_m, cchs2015_2016_m, cchs2017_2018_m","DerivedVar::[ADL_01, ADL_02, ADL_03, ADL_04, ADL_05]",,N/A,5,6,Needs help with at least 5 tasks,Needs help with at least 5 tasks,N/A,N/A,Needs help with at least 5 tasks,ADL score,"Derived using the ADL variables common to all cycles from 2001 to 2014 (ADL_01, ADL_02, ADL_03, ADL_04, ADL_05) to represent the number of tasks that an individual needs help with.",,,,active,,No typeStart | ||
| ADL_score_5,ADL_score_5_cat6_NA::a,cat,"cchs2001_p, cchs2003_p, cchs2005_p, cchs2007_2008_p, cchs2009_2010_p, cchs2010_p, cchs2011_2012_p, cchs2012_p, cchs2013_2014_p, cchs2014_p, cchs2015_2016_p, cchs2017_2018_p, cchs2001_m, cchs2003_m, cchs2005_m, cchs2007_2008_m, cchs2009_2010_m, cchs2009_m, cchs2010_m, cchs2011_2012_m, cchs2012_m, cchs2013_2014_m, cchs2015_2016_m, cchs2017_2018_m","DerivedVar::[ADL_01, ADL_02, ADL_03, ADL_04, ADL_05]",,N/A,NA::a,6,not applicable,not applicable,N/A,N/A,not applicable,ADL score,"Derived using the ADL variables common to all cycles from 2001 to 2014 (ADL_01, ADL_02, ADL_03, ADL_04, ADL_05) to represent the number of tasks that an individual needs help with.",,,,active,,No typeStart | ||
| ADL_score_5,ADL_score_5_cat6_NA::b,cat,"cchs2001_p, cchs2003_p, cchs2005_p, cchs2007_2008_p, cchs2009_2010_p, cchs2010_p, cchs2011_2012_p, cchs2012_p, cchs2013_2014_p, cchs2014_p, cchs2015_2016_p, cchs2017_2018_p, cchs2001_m, cchs2003_m, cchs2005_m, cchs2007_2008_m, cchs2009_2010_m, cchs2009_m, cchs2010_m, cchs2011_2012_m, cchs2012_m, cchs2013_2014_m, cchs2015_2016_m, cchs2017_2018_m","DerivedVar::[ADL_01, ADL_02, ADL_03, ADL_04, ADL_05]",,N/A,NA::b,6,missing,missing,N/A,N/A,missing,ADL score,"Derived using the ADL variables common to all cycles from 2001 to 2014 (ADL_01, ADL_02, ADL_03, ADL_04, ADL_05) to represent the number of tasks that an individual needs help with.",,,,active,,No typeStart | ||
| ADL_score_6,ADL_score_6_catN/A_Func::score_adl_6,cat,"cchs2003_p, cchs2005_p, cchs2007_2008_p, cchs2009_2010_p, cchs2010_p, cchs2011_2012_p, cchs2012_p, cchs2013_2014_p, cchs2014_p, cchs2015_2016_p, cchs2017_2018_p, cchs2003_m, cchs2005_m, cchs2007_2008_m, cchs2009_2010_m, cchs2009_m, cchs2010_m, cchs2011_2012_m, cchs2012_m, cchs2013_2014_m, cchs2015_2016_m, cchs2017_2018_m","DerivedVar::[ADL_01, ADL_02, ADL_03, ADL_04, ADL_05, ADL_06]",ICES specifc,N/A,Func::score_adl_6,N/A,N/A,N/A,N/A,N/A,N/A,ADL score,"Derived using the ADL variables used in DemPoRT from 2001 to 2014 (ADL_01, ADL_02, ADL_03, ADL_04, ADL_05, ADL_06) to represent the number of tasks that an individual needs help with.",,,,active,v3.0.0alpha,No typeStart |
Collaborator
There was a problem hiding this comment.
Line 127 refers to the function in R/adl.R, but there's a whole another file called R/adl_score_6.R with a lot of unused functions put in the R/legacy/adl-legacy.R. Should we only keep functions (and in turn files) which are being used to derive variables and as helpers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2015-2016 and 2017-2018 master files cycles added to ADL_01, ADL_02, ADL_03, ADL_04, ADL_05, ADL_06 in variable_details
2015-2016 and 2017-2018 master file cycles added to ADL_01-ADL_06 in variables.csv
Note: ADL module not completed in Ontario for 2015-2016 and 2017-2018 but was completed in other provinces. Therefore, for completeness, these master survey cycles were still included.