Skip to content

chore: bump claws version number + enable the new rule#4

Merged
6f6d6172 merged 3 commits into
mainfrom
os-upgrade-claws
Sep 2, 2025
Merged

chore: bump claws version number + enable the new rule#4
6f6d6172 merged 3 commits into
mainfrom
os-upgrade-claws

Conversation

@6f6d6172
Copy link
Copy Markdown
Contributor

Claws has had a couple of changes since the last version. This updates the version we're using for the org and also updates the claws configuration file to enable the new rule that was added in Betterment/claws#7. Need to wait on Betterment/claws#8 being merged first though!

@6f6d6172 6f6d6172 requested review from Copilot and cosmosbit August 26, 2025 16:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the claws security scanning tool to version 0.9.0 and enables a new security rule for detecting static credential usage in GitHub Actions checkout operations.

  • Updates claws-scan version from 0.7.3 to 0.9.0
  • Enables the new CheckoutWithStaticCredentials rule in the claws configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/claws.yml Updates gem installation to use claws-scan version 0.9.0
claws/config.yml Adds CheckoutWithStaticCredentials rule to the enabled security checks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@6f6d6172
Copy link
Copy Markdown
Contributor Author

6f6d6172 commented Aug 26, 2025

Heh, Claws is failing in this PR because it's trying to use the old version with the new config... to be honest I'm not sure how that's possible since the new config isn't even on main yet?

edit: oh the workflow is running on main, and actions/checkout pulls from the head of the branch, which for this PR, contains the new config option. duh

@6f6d6172 6f6d6172 closed this Aug 26, 2025
@6f6d6172 6f6d6172 reopened this Aug 26, 2025
cosmosbit
cosmosbit approved these changes Aug 26, 2025
… check out the PR version instead... annoying!
@6f6d6172
Copy link
Copy Markdown
Contributor Author

6f6d6172 commented Sep 2, 2025

edit: oh the workflow is running on main, and actions/checkout pulls from the head of the branch, which for this PR, contains the new config option. duh

This ended up causing this PR to be unmergeable. I updated the workflow to always fetch main, so the version of claws and its configuration are always in sync! This would have only blocked PRs in this repo, nowhere else, so if we were somehow able to merge it, we'd still be fine.

Copy link
Copy Markdown

@cosmosbit cosmosbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm

@6f6d6172
Copy link
Copy Markdown
Contributor Author

6f6d6172 commented Sep 2, 2025

/no-platform

Copy link
Copy Markdown

@lindan-betterment lindan-betterment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm

@6f6d6172 6f6d6172 merged commit de1c10c into main Sep 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants