fix: agent sandbox 0.4.6 service creation is opt in#151
Conversation
Greptile SummaryThis PR opts in to headless Service creation in agent-sandbox 0.4.6 by adding
Confidence Score: 3/5The runtime intent is correct, but the TypeScript compiler will reject the change because The single-line addition is functionally correct for the 0.4.6 breaking change, but the accompanying interface definition was not updated, so the TypeScript build will fail. src/server/k8s.ts — the
|
| Filename | Overview |
|---|---|
| src/server/k8s.ts | Adds service: true to the Sandbox spec to opt in to headless Service creation in agent-sandbox 0.4.6, but the SandboxSpec interface is not updated to include the service field, causing a TypeScript build failure. |
Comments Outside Diff (1)
-
src/server/k8s.ts, line 504-515 (link)The
SandboxSpecinterface doesn't declare aservicefield, so assigningservice: truehere will fail TypeScript's excess-property check and break the build. The interface needs to be extended to accept the new field.
Reviews (1): Last reviewed commit: "fix: agent sandbox 0.4.6 service creatio..." | Re-trigger Greptile
|
@tarekabouzeid can you address greptile's comments here ? |
Breaking change in agent sandbox 0.4.6 where service creation is opt in.
The platform relies on headless Service DNS for in-cluster sandbox health checks and session routing, without this change the agent fails checks and not able to proceed spawning.