Skip to content

fix: agent sandbox 0.4.6 service creation is opt in#151

Open
tarekabouzeid wants to merge 1 commit into
BerriAI:mainfrom
tarekabouzeid:fix-service-creation-opt-in
Open

fix: agent sandbox 0.4.6 service creation is opt in#151
tarekabouzeid wants to merge 1 commit into
BerriAI:mainfrom
tarekabouzeid:fix-service-creation-opt-in

Conversation

@tarekabouzeid
Copy link
Copy Markdown

Breaking change in agent sandbox 0.4.6 where service creation is opt in.

The platform relies on headless Service DNS for in-cluster sandbox health checks and session routing, without this change the agent fails checks and not able to proceed spawning.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 17, 2026

Greptile Summary

This PR opts in to headless Service creation in agent-sandbox 0.4.6 by adding service: true to the SandboxResource spec in runTask, which is required for in-cluster DNS-based health checks and session routing.

  • service: true is added to the SandboxResource spec object in src/server/k8s.ts, but the SandboxSpec TypeScript interface is not updated to include the new field — this will produce an excess-property type error and fail the build.

Confidence Score: 3/5

The runtime intent is correct, but the TypeScript compiler will reject the change because SandboxSpec is missing the service field.

The single-line addition is functionally correct for the 0.4.6 breaking change, but the accompanying interface definition was not updated, so the TypeScript build will fail.

src/server/k8s.ts — the SandboxSpec interface needs service?: boolean added alongside the new runtime field.

Important Files Changed

Filename Overview
src/server/k8s.ts Adds service: true to the Sandbox spec to opt in to headless Service creation in agent-sandbox 0.4.6, but the SandboxSpec interface is not updated to include the service field, causing a TypeScript build failure.

Comments Outside Diff (1)

  1. src/server/k8s.ts, line 504-515 (link)

    P1 The SandboxSpec interface doesn't declare a service field, so assigning service: true here will fail TypeScript's excess-property check and break the build. The interface needs to be extended to accept the new field.

Reviews (1): Last reviewed commit: "fix: agent sandbox 0.4.6 service creatio..." | Re-trigger Greptile

@ishaan-berri
Copy link
Copy Markdown
Contributor

@tarekabouzeid can you address greptile's comments here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants