Skip to content

AP595: Stack Pass Request admin form showing Forbidden when not logged in #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yzhoubk merged 4 commits into from
Feb 26, 2026
Merged

AP595: Stack Pass Request admin form showing Forbidden when not logged in #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e06cce
Add authenticate before checking user role
yzhoubk Feb 24, 2026
c3f5a82
Add authanticate before checking role in referece-card; and some robo…
yzhoubk Feb 25, 2026
d233410
Revert some spec files that were automatically updated by rubocop -a
yzhoubk Feb 25, 2026
37c833f
Add authanticate before checking role in referece-card form
yzhoubk Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/reference_card_forms_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def validate_recaptcha!
end

def require_admin!
authenticate!
@user_is_admin = current_user.role?(Role.stackpass_admin)
raise Error::ForbiddenError unless @user_is_admin
end
Expand Down
1 change: 1 addition & 0 deletions app/controllers/stack_pass_forms_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def validate_recaptcha!
end

def require_admin!
authenticate!
@user_is_admin = current_user.role?(Role.stackpass_admin)
raise Error::ForbiddenError unless @user_is_admin
end
Expand Down