-
Notifications
You must be signed in to change notification settings - Fork 1
Ap 587 update dependencies #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davezuckerman
wants to merge
29
commits into
main
Choose a base branch
from
AP-587-update-dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,571
−1,738
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
7b40fd3
upgrades for Rails 8
86fa80b
dependency updates
5aec166
Pagy uses pagy.limit now for number of items on page
1b1651c
updating depencies, moving to rails 8.0.4, ruby 3.4 and pagy 43
16c1a70
increased memory for tests
5232e92
increased memomory for app for tests, only run tests if setup succeeds
f38e87f
changed based url for IIF server, removed memory allocation for compo…
29d8df3
using selenium stand alone chrome, broke out steps in build.yml for p…
e81dbe2
bringin up selenium after assets are precompiled, lowering the reserv…
26b174c
bypassing yarn build -watch in ci since assets are precompiled in a d…
5a8f763
only start selenium before rspec needs it
947f3bc
bringing up compose without dependencies so sellenium doesn't start u…
d36596b
running precompile as a standalone. hope this fixes memory issue when…
1e27edf
using dummy key_base for precompile
70dcef9
for rspec need to have iipsrv, app and selenium running
ce23cd9
for rspec need to have iipsrv, app and selenium running
027e216
need bundle exec when calling rspec and rubocop
6186f89
full rails server not needed for tests, using slimmed down version fo…
b85b856
running system tests as stand alone
2558ccd
adding sleep infinity to docker-compose.ci, hopefully fixes memory is…
81d2b19
refactored do_profile in application_controller
8f8d748
Added omniauth-rails_csrf_protection gem and updated omniauth intiali…
44c2021
removed twitter/x logo from footer and deleted icon
9538275
removed commented out code, set config.yjit false and removed sleep i…
20f72a5
ran rails app:update and made necessary changes to accommodate the up…
davezuckerman 402beb9
added sleep infinity back in to compose.ci, tests failing in build wi…
davezuckerman ab39ba3
changed unauthorized user redirect so it goes to a page instead of di…
davezuckerman 7413da5
removed some Gem dependencies, changed a comment in puma config, adde…
davezuckerman 9824c11
fixed a fex minor styling issues in specs
davezuckerman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.2.2 | ||
| 3.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ | |
| # yarn lockfile v1 | ||
|
|
||
|
|
||
| lastUpdateCheck 1770150293563 | ||
| lastUpdateCheck 1771868064007 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of our apps are on 3.3; I don't have a problem with 3.4, but should we be trying to unify them all to a single version? (should 3.4, or even 4.0, be something we look to in a future sprint?)