Conversation
Review Summary by QodoAdd mailpit 1.29.2 configuration and update bundle version
WalkthroughsDescription• Add mailpit version 1.29.2 configuration file • Update bundle release version to 2026.3.5 Diagramflowchart LR
A["New mailpit 1.29.2 config"] -- "defines settings" --> B["bearsampp.conf"]
C["build.properties"] -- "version bump" --> D["2026.3.5 release"]
File Changes1. bin/mailpit1.29.2/bearsampp.conf
|
Code Review by Qodo
1. releaseAll fails for 1.29.2
|
Comment on lines
+1
to
+6
| mailpitVersion = "1.29.2" | ||
| mailpitExe = "mailpit.exe" | ||
| mailpitWebRoot = "mail" | ||
| mailpitUiPort = "8025" | ||
| mailpitSmtpPort = "25" | ||
| mailpitListen = "127.0.0.1" |
There was a problem hiding this comment.
1. Releaseall fails for 1.29.2 🐞 Bug ⛯ Reliability
The new bin/mailpit1.29.2/ directory contains only bearsampp.conf (no mailpit.exe), but releaseAll requires mailpit.exe to exist in each discovered version directory and hard-fails otherwise. This makes gradle releaseAll fail when it reaches version 1.29.2 (and in a clean checkout, likely fails for other versions too).
Agent Prompt
## Issue description
`releaseAll` hard-requires `mailpit.exe` to exist in each version directory under `bin/`/`bin/archived/`, but version directories in this repo (including the newly added `mailpit1.29.2`) may contain only `bearsampp.conf`. Unlike the single-version `release` task, `releaseAll` does not attempt to use cached extracted binaries or download them. This causes `gradle releaseAll` to fail for 1.29.2.
## Issue Context
- `getAvailableVersions()` automatically discovers `bin/mailpit1.29.2`, so it will be included in `releaseAll`.
- `release` already contains a fallback to use cached extraction or download when `mailpit.exe` is missing.
## Fix Focus Areas
- build.gradle[842-888]
- build.gradle[640-676]
- build.gradle[383-407]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.