Skip to content

Update mailpit version to 1.29.2 in configuration file#26

Merged
jwaisner merged 1 commit intomainfrom
1.29.2
Mar 8, 2026
Merged

Update mailpit version to 1.29.2 in configuration file#26
jwaisner merged 1 commit intomainfrom
1.29.2

Conversation

@N6REJ
Copy link
Copy Markdown
Contributor

@N6REJ N6REJ commented Mar 5, 2026

No description provided.

@N6REJ N6REJ added enhancement ✨ Improve program Security 🔐 Security issue labels Mar 5, 2026
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Add mailpit 1.29.2 configuration and update bundle version

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add mailpit version 1.29.2 configuration file
• Update bundle release version to 2026.3.5
Diagram
flowchart LR
  A["New mailpit 1.29.2 config"] -- "defines settings" --> B["bearsampp.conf"]
  C["build.properties"] -- "version bump" --> D["2026.3.5 release"]
Loading

Grey Divider

File Changes

1. bin/mailpit1.29.2/bearsampp.conf ⚙️ Configuration changes +6/-0

New mailpit 1.29.2 configuration file

• Create new configuration file for mailpit version 1.29.2
• Define mailpit executable, web root, UI port, SMTP port, and listen address
• Configure standard mailpit settings with port 8025 for UI and port 25 for SMTP

bin/mailpit1.29.2/bearsampp.conf


2. build.properties ⚙️ Configuration changes +1/-1

Update bundle release version

• Update bundle release version from 2026.1.15 to 2026.3.5
• Reflect new release date in build configuration

build.properties


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Mar 5, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. releaseAll fails for 1.29.2 🐞 Bug ⛯ Reliability
Description
The new bin/mailpit1.29.2/ directory contains only bearsampp.conf (no mailpit.exe), but
releaseAll requires mailpit.exe to exist in each discovered version directory and hard-fails
otherwise. This makes gradle releaseAll fail when it reaches version 1.29.2 (and in a clean
checkout, likely fails for other versions too).
Code

bin/mailpit1.29.2/bearsampp.conf[R1-6]

+mailpitVersion = "1.29.2"
+mailpitExe = "mailpit.exe"
+mailpitWebRoot = "mail"
+mailpitUiPort = "8025"
+mailpitSmtpPort = "25"
+mailpitListen = "127.0.0.1"
Evidence
getAvailableVersions() discovers versions by scanning bin/ for directories starting with
mailpit, so adding bin/mailpit1.29.2/ automatically includes 1.29.2 in the releaseAll loop.
In releaseAll, the build throws if ${bundleSrcFinal}/mailpit.exe does not exist, and unlike the
single-version release task, there is no download/extract fallback when the binary is missing.

build.gradle[383-407]
build.gradle[842-888]
build.gradle[643-676]
bin/mailpit1.29.2/bearsampp.conf[1-6]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`releaseAll` hard-requires `mailpit.exe` to exist in each version directory under `bin/`/`bin/archived/`, but version directories in this repo (including the newly added `mailpit1.29.2`) may contain only `bearsampp.conf`. Unlike the single-version `release` task, `releaseAll` does not attempt to use cached extracted binaries or download them. This causes `gradle releaseAll` to fail for 1.29.2.

## Issue Context
- `getAvailableVersions()` automatically discovers `bin/mailpit1.29.2`, so it will be included in `releaseAll`.
- `release` already contains a fallback to use cached extraction or download when `mailpit.exe` is missing.

## Fix Focus Areas
- build.gradle[842-888]
- build.gradle[640-676]
- build.gradle[383-407]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment on lines +1 to +6
mailpitVersion = "1.29.2"
mailpitExe = "mailpit.exe"
mailpitWebRoot = "mail"
mailpitUiPort = "8025"
mailpitSmtpPort = "25"
mailpitListen = "127.0.0.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Releaseall fails for 1.29.2 🐞 Bug ⛯ Reliability

The new bin/mailpit1.29.2/ directory contains only bearsampp.conf (no mailpit.exe), but
releaseAll requires mailpit.exe to exist in each discovered version directory and hard-fails
otherwise. This makes gradle releaseAll fail when it reaches version 1.29.2 (and in a clean
checkout, likely fails for other versions too).
Agent Prompt
## Issue description
`releaseAll` hard-requires `mailpit.exe` to exist in each version directory under `bin/`/`bin/archived/`, but version directories in this repo (including the newly added `mailpit1.29.2`) may contain only `bearsampp.conf`. Unlike the single-version `release` task, `releaseAll` does not attempt to use cached extracted binaries or download them. This causes `gradle releaseAll` to fail for 1.29.2.

## Issue Context
- `getAvailableVersions()` automatically discovers `bin/mailpit1.29.2`, so it will be included in `releaseAll`.
- `release` already contains a fallback to use cached extraction or download when `mailpit.exe` is missing.

## Fix Focus Areas
- build.gradle[842-888]
- build.gradle[640-676]
- build.gradle[383-407]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@jwaisner jwaisner merged commit 2f56da2 into main Mar 8, 2026
2 checks passed
@jwaisner jwaisner deleted the 1.29.2 branch March 8, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program Security 🔐 Security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants