Skip to content

feat(#2): ClickOnce publishing support #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ModerRAS wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(#2): ClickOnce publishing support #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions BannerlordModEditor.UI/BannerlordModEditor.UI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
<NoWarn>$(NoWarn);CS8618;CS8603;CS8604;CS8602;CS8600;CS8625</NoWarn>
</PropertyGroup>

<PropertyGroup Condition="'$([MSBuild]::IsOSPlatform(Windows))' == 'true'">
<PublishSingleFile>true</PublishSingleFile>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
Comment on lines 12 to +17
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gating publish settings on the host OS (IsOSPlatform(Windows)) makes Windows packaging non-reproducible from non-Windows environments (e.g., CI on Linux building -r win-x64). Prefer conditioning on the target (e.g., $(RuntimeIdentifier)/$(TargetFramework)), or move these properties into the ClickOnce .pubxml so they apply when that profile is used regardless of the build agent OS.

Suggested change
</PropertyGroup>
<PropertyGroup Condition="'$([MSBuild]::IsOSPlatform(Windows))' == 'true'">
<PublishSingleFile>true</PublishSingleFile>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
</PropertyGroup>
<PropertyGroup Condition="'$(RuntimeIdentifier)' == 'win-x64'">
<PublishSingleFile>true</PublishSingleFile>
<SelfContained>true</SelfContained>

Copilot uses AI. Check for mistakes.
<PublishReadyToRun>true</PublishReadyToRun>
<IncludeNativeLibrariesForSelfExtract>true</IncludeNativeLibrariesForSelfExtract>
Comment on lines +15 to +19
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are publish-profile-specific knobs (single-file/self-contained/RID/ReadyToRun). Defining them at the project level can unintentionally affect all publish modes on Windows and forces RID-specific restore/asset selection. Consider moving SelfContained, RuntimeIdentifier, and related publish settings into ClickOnceProfile.pubxml (or scoping them to that profile via conditions) so regular dev builds and other publish flows aren’t implicitly locked to win-x64/self-contained output.

Copilot uses AI. Check for mistakes.
</PropertyGroup>

<ItemGroup>
<Folder Include="Models\" />
</ItemGroup>
Expand Down
Loading