Close sqlite connections in SqliteAccountInfo#566
Open
olzhasar-reef wants to merge 3 commits intomasterfrom
Open
Close sqlite connections in SqliteAccountInfo#566olzhasar-reef wants to merge 3 commits intomasterfrom
olzhasar-reef wants to merge 3 commits intomasterfrom
Conversation
Collaborator
olzhasar-reef
commented
Mar 3, 2026
olzhasar-reef
commented
- Add close method to SqliteAccountInfo, explicitly close temporary connections
- Refactor account_info tests, close used sqlite connections
olzhasar-reef
commented
Mar 3, 2026
| raw_api = B2RawHTTPApi(B2Http()) | ||
| raw_api_test_helper(raw_api, not dont_cleanup_old_buckets) | ||
| except Exception: | ||
| traceback.print_exc(file=sys.stdout) |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure what was the reasoning behind that logic, but we used to end up with unhelpful error messages like the following:
> pytest.fail('test_raw_api failed')
E Failed: test_raw_api failed
test/integration/test_raw_api.py:78: Failed
mlech-reef
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.