Use native node for running the bot#562
Open
JstnMcBrd wants to merge 10 commits into
Open
Conversation
Contributor
Author
|
The branch protection rules need to be updated to expect |
| "dectalk-tts": "1.0.1", | ||
| "discord.js": "14.26.4", | ||
| "ffmpeg-static": "5.3.0", | ||
| "source-map-support": "0.5.21", |
Contributor
There was a problem hiding this comment.
If we go this route, we can probably do away with source-map-support too, since we no longer have a "build" stage to generate those.
|
|
||
| ENV NODE_ENV=production | ||
|
|
||
| RUN apt-get update -y |
Contributor
There was a problem hiding this comment.
Not sure about removing this line. Shouldn't we update the package lists before trying to install packages?
Contributor
|
I'm not sure on removing the "build" stage yet. I'm hoping to eventually set up something like Rollup so we can tree-shake and avoid including node_modules in the final bundle, and setting that up would require reinstating that build step and possibly undoing this entire PR later 😓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #541
Modernizes and simplifies our setup
Changes
.jsto.tserasableSyntaxOnlysrc/main.tsdistDockerfileto reflect build changes