Conversation
LarsV123
reviewed
May 21, 2026
Eiriknil
commented
May 21, 2026
LarsV123
requested changes
May 21, 2026
| @@ -6,7 +6,7 @@ phases: | |||
| java: corretto21 | |||
| nodejs: 24 | |||
| commands: | |||
| - npm install allure | |||
| - npm install allure@3.8.2 | |||
Contributor
There was a problem hiding this comment.
Note that this pins the direct dependency, but not the transitive dependencies, since we don't have a lockfile. Means we don't have any real guarantee about which versions are actually used for those on each test run.
Contributor
Author
There was a problem hiding this comment.
Not sure how to do this in the best way
added 2 commits
May 26, 2026 12:09
LarsV123
reviewed
May 27, 2026
…ex/BibTexTest.java Co-authored-by: Lars-Olav Vågene <42863501+LarsV123@users.noreply.github.com>
LarsV123
approved these changes
May 27, 2026
|
|
||
| @ParameterizedTest | ||
| @MethodSource("publicationsInBibTexFormatProvider") | ||
| void shouldReturnPublicationsInBibTexFormat(Category category, BibTexExpectation expectation) { |
Contributor
There was a problem hiding this comment.
Since Allure uses DisplayName for test reports, should probably add that here too? Seems to be parameterized properly automatically. For example @DisplayName("Search with content type 'text/x-bibtex' produces BibTeX export")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added BibText module to gradle project
Added tests for export to bibtex for AcademicArticle and AcademicMonograph
parameterized publish test in publication-api module