Cache git status in cl_stage and cl_commit#40
Merged
Conversation
Previously, cl_stage and cl_commit called clutil_is_file_untracked once per file in the changelist, each time shelling out to git status. For a changelist of N files in a working tree with R files, this scaled as O(N × R) — noticeable on large repos. Add clutil_is_file_untracked_cached, which takes a precomputed status map. Update cl_stage and cl_commit to fetch the status map once at the top and look up per-file status from the cached dict. Behaviour is unchanged; cl_unstage already used this pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, cl_stage and cl_commit called clutil_is_file_untracked once per file in the changelist, each time shelling out to git status. For a changelist of N files in a working tree with R files, this scaled as O(N × R) — noticeable on large repos.
Add clutil_is_file_untracked_cached, which takes a precomputed status map. Update cl_stage and cl_commit to fetch the status map once at the top and look up per-file status from the cached dict. Behaviour is unchanged; cl_unstage already used this pattern.