feat: add support for scheduling against kubernetes.azure.com/fips_enabled#1438
Open
feat: add support for scheduling against kubernetes.azure.com/fips_enabled#1438
Conversation
tallaxes
previously approved these changes
Feb 18, 2026
matthchr
force-pushed
the
matthchr/fips-label
branch
from
44738f0 to
1599e3d
Compare
…abled * This adds the ability to simulate scheduling against the label but note that workloads cannot control the FIPS mode of their nodes by specifying kubernetes.azure.com/fips_enabled: true. The actual FIPS mode of provisioned nodes is still controlled by the field on the AKSNodeClass. * As before, FIPS capability only works in NAP, not OSS Karpenter.
matthchr
force-pushed
the
matthchr/fips-label
branch
from
1599e3d to
1bd5057
Compare
Member
Author
|
E2E uncovered a (test) issue, where I had failed to add the label to the I've fixed that and requeued a fresh E2E |
matthchr
force-pushed
the
matthchr/fips-label
branch
from
e1718cf to
88230ac
Compare
tallaxes
reviewed
Feb 21, 2026
Comment on lines
+2347
to
+2348
| testOptions.UseSIG = true | ||
| ctx = options.ToContext(ctx, testOptions) |
Collaborator
There was a problem hiding this comment.
Wouldn't this (once executed) persist for subsequent tests here? (Even if yes, maybe it does not matter since tests pass, but feels weird ...)
Member
Author
There was a problem hiding this comment.
ctx = options.ToContext(ctx, test.Options()) is in BeforeEach, so I think no?
Collaborator
There was a problem hiding this comment.
Hmm, yes, so ctx should be fine. But top-level BeforeEach also does test.ApplyDefaultStatus(nodeClass, env, testOptions.UseSIG), do we care about images in status? Probably not ...
tallaxes
reviewed
Feb 21, 2026
matthchr
force-pushed
the
matthchr/fips-label
branch
from
88230ac to
f045386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How was this change tested?
Does this change impact docs?
Release Note