chore: Address kube-api-linter warnings about optional fields#1432
Open
theunrepentantgeek wants to merge 7 commits intomainfrom
Open
chore: Address kube-api-linter warnings about optional fields#1432theunrepentantgeek wants to merge 7 commits intomainfrom
theunrepentantgeek wants to merge 7 commits intomainfrom
Conversation
tallaxes
reviewed
Feb 18, 2026
| ImageGCHighThresholdPercent: lo.ToPtr(int32(85)), | ||
| ImageGCLowThresholdPercent: lo.ToPtr(int32(80)), | ||
| TopologyManagerPolicy: "none", | ||
| TopologyManagerPolicy: to.Ptr("none"), |
Collaborator
There was a problem hiding this comment.
Consider (here and elsewhere) using lo.ToPtr instead; already used widely in the codebase (and nearby)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
In #1387 we enabled the
kube-api-linterfor checks, but simply suppressed all existing warnings.Here we address most occurences of the
optionalfieldssublinter, converting fields into pointers and updating all consumption.This is non-breaking for YAML consumption, but breaking for code consumption.
How was this change tested?
Local testing using
make testand will run CI checks too.Does this change impact docs?
Release Note