Merged
Conversation
Member
cartertinney
commented
Mar 23, 2026
- Updated all crates to indicate MSRV (Minimum Supported Rust Version) is 1.88.
- Note that this is just a formalization of what we've been using by convention up until now - it's possible we could loosen this restriction further in the future, but would require investigation.
- Can be set in the workspace for most crates, but the connector scaffolding needs to be independently defined due to not being part of the workspace (and being a scaffold for customer applications that will not use our workspace)
- CI that runs both MSRV and latest stable will be a follow up
Contributor
There was a problem hiding this comment.
Pull request overview
This PR formalizes the Rust Minimum Supported Rust Version (MSRV) across the Rust workspace as Rust 1.88, aligning crate metadata and local developer tooling with the version already used by convention.
Changes:
- Set workspace-wide MSRV via
rust/Cargo.tomland opt member crates into inheriting it viarust-version.workspace = true. - Pin the Rust toolchain used for local development to
1.88viarust/rust-toolchain.toml. - Define MSRV explicitly for the excluded
sample_connector_scaffoldingcrate since it is not part of the workspace.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/Cargo.toml | Defines workspace MSRV ([workspace.package] rust-version = "1.88"). |
| rust/rust-toolchain.toml | Pins local dev toolchain channel to 1.88. |
| rust/azure_iot_operations_mqtt/Cargo.toml | Inherits MSRV from workspace. |
| rust/azure_iot_operations_protocol/Cargo.toml | Inherits MSRV from workspace. |
| rust/azure_iot_operations_services/Cargo.toml | Inherits MSRV from workspace. |
| rust/azure_iot_operations_connector/Cargo.toml | Inherits MSRV from workspace. |
| rust/sample_applications/counter/envoy/Cargo.toml | Inherits MSRV from workspace. |
| rust/sample_applications/counter/counter_server/Cargo.toml | Inherits MSRV from workspace. |
| rust/sample_applications/counter/counter_client/Cargo.toml | Inherits MSRV from workspace. |
| rust/sample_applications/event_driven_app/input_client/Cargo.toml | Inherits MSRV from workspace. |
| rust/sample_applications/event_driven_app/output_client/Cargo.toml | Inherits MSRV from workspace. |
| rust/sample_applications/sample_connector_scaffolding/Cargo.toml | Sets explicit MSRV (rust-version = "1.88") since it’s excluded from the workspace. |
vaavva
approved these changes
Mar 23, 2026
RLeclair
approved these changes
Apr 16, 2026
RLeclair
added a commit
that referenced
this pull request
Apr 20, 2026
- Updated all crates to indicate MSRV (Minimum Supported Rust Version) is 1.88. - Note that this is just a formalization of what we've been using by convention up until now - it's possible we could loosen this restriction further in the future, but would require investigation. - Can be set in the workspace for most crates, but the connector scaffolding needs to be independently defined due to not being part of the workspace (and being a scaffold for customer applications that will not use our workspace) - CI that runs both MSRV and latest stable will be a follow up Co-authored-by: Carter Tinney <catinney@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.