Skip to content

Properly initialize content handler logging#828

Open
AndreRicardo-Zoetis wants to merge 6 commits intoAzure:developfrom
AndreRicardo-Zoetis:fix-780-missing-curl-logs
Open

Properly initialize content handler logging#828
AndreRicardo-Zoetis wants to merge 6 commits intoAzure:developfrom
AndreRicardo-Zoetis:fix-780-missing-curl-logs

Conversation

@AndreRicardo-Zoetis
Copy link
Copy Markdown
Contributor

@AndreRicardo-Zoetis AndreRicardo-Zoetis commented Feb 26, 2026

I know you just cleared all Pull Requests, congrats! 😅

Fix #780 show curl logs.

While testing noticed that logLevel was not passed to contentDownloader, needed to pass logLevel so it works as expected for different -l parameters.

image

do-client logs were also missing, added initialization now.

deliveryoptimization is harder to test for us but did a full build and could see the do_download logs now:

image

Other changes:

  • Added clean up logic when the library is being unloaded and renamed variable for consistency.

@AndreRicardo-Zoetis AndreRicardo-Zoetis changed the title Properly initialize curl content handler logging Properly initialize content handler logging Feb 26, 2026
@Nox-MSFT
Copy link
Copy Markdown
Collaborator

Nox-MSFT commented Mar 6, 2026

@AndreRicardo-Zoetis - thanks for the PR. The changes look good, but I’m a bit concerned this could break others who have built custom content download handlers. We may want to consider a backward‑compatible approach (e.g., build flag or runtime check) to support both old and new ABIs.

@AndreRicardo-Zoetis
Copy link
Copy Markdown
Contributor Author

AndreRicardo-Zoetis commented Mar 27, 2026

@AndreRicardo-Zoetis - thanks for the PR. The changes look good, but I’m a bit concerned this could break others who have built custom content download handlers. We may want to consider a backward‑compatible approach (e.g., build flag or runtime check) to support both old and new ABIs.

Ok, but won't they have the same problem of the severity not being passed? Are these customers seeing their logs without the parameter?

Also the initializeData is only needed from what I can tell in do-client, while the log level is used by both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

curl content downloader logs not printing

2 participants