Open
Conversation
RubenCerna2079
changed the title
RubenCerna2079
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
souvikghosh04,
stuartpa and
vadeveka
as code owners
RubenCerna2079
force-pushed
the
dev/rubencerna/update-validation-autoentities
branch
from
7445062 to
5a0b722
Compare
Base automatically changed from
dev/rubencerna/create-inmemory-entities-from-autoentities
to
main
February 26, 2026 19:48
RubenCerna2079
dismissed
anushakolan’s stale review
The base branch was changed.
Aniruddh25
reviewed
Feb 26, 2026
Aniruddh25
reviewed
Feb 26, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
anushakolan
approved these changes
Feb 27, 2026
Contributor
anushakolan
left a comment
anushakolan
left a comment
There was a problem hiding this comment.
Have some minor suggestion, but rest LGTM!
Aniruddh25
reviewed
Feb 28, 2026
| subStatusCode: DataApiBuilderException.SubStatusCodes.ErrorInInitialization); | ||
| } | ||
|
|
||
| runtimeConfigValidator.ValidateEntityAndAutoentityConfigurations(runtimeConfig); |
Collaborator
There was a problem hiding this comment.
Was the validation being executed even for CosmosDB previously?
Aniruddh25
reviewed
Feb 28, 2026
Aniruddh25
reviewed
Feb 28, 2026
Aniruddh25
reviewed
Feb 28, 2026
Aniruddh25
requested changes
Feb 28, 2026
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
ValidateEntitiesMetadata needs to be called as well.
github-project-automation
bot
moved this from Todo
to Review In Progress
in Data API builder
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
The current validation for DAB occurs before the section where the autoentities are generated. In order to ensure that all the entities that are generated from the autoentities, we need to move the part of the validation that takes care of ensuring the entities don't have the same REST paths or the same GraphQL types.
What is this change?
How was this tested?