Skip to content

{CI} Sync squad mapping into resourceManagement.yml#29328

Open
azure-powershell-bot wants to merge 2 commits intomainfrom
internal/sync-squad-mapping
Open

{CI} Sync squad mapping into resourceManagement.yml#29328
azure-powershell-bot wants to merge 2 commits intomainfrom
internal/sync-squad-mapping

Conversation

@azure-powershell-bot
Copy link
Copy Markdown
Collaborator

Description

This PR synchronizes squad labels, reviewers and mentionees into resourceManagement.yml based on the Squad Mapping wiki.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings March 27, 2026 01:19
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitOps issue/PR management policy to align squad routing (mentionees and labels) in .github/policies/resourceManagement.yml with the current Squad Mapping wiki.

Changes:

  • Adds ACT squad entries to multiple mentionUsers mentionee lists so the right squad is CC’d during “Service Attention” routing.
  • Adds addLabel actions to apply the corresponding ACT squad label when routing conditions match.

then:
- mentionUsers:
mentionees:
- Elsie4ever,MohinderAtwal
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentionees entry Elsie4ever,MohinderAtwal appears to combine two GitHub users with a full-width comma, which will be treated as a single (invalid) handle and won’t notify either user. Split this into two separate mentionees list items (and use standard ASCII punctuation).

Suggested change
- Elsie4ever,MohinderAtwal
- Elsie4ever
- MohinderAtwal

Copilot uses AI. Check for mistakes.
then:
- mentionUsers:
mentionees:
- arc-enabled-vms-on-hci Team
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arc-enabled-vms-on-hci Team contains spaces, so it is not a valid GitHub username or org/team slug and won’t produce an actual mention in the generated comment. Replace it with the correct GitHub handle/team slug (or split into valid individual handles) so the routing notification works.

Suggested change
- arc-enabled-vms-on-hci Team
- arc-enabled-vms-on-hci-team

Copilot uses AI. Check for mistakes.
@azure-powershell-bot azure-powershell-bot force-pushed the internal/sync-squad-mapping branch from 374a354 to 5561c81 Compare March 27, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants