Do not review-powershell cmdlet by anamikapan11 · Pull Request #29324 · Azure/azure-powershell

anamikapan11 · 2026-03-26T05:57:17Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2026-03-26T05:57:21Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull request overview

This PR updates the Az.Resources module to support Deployment Stacks What-If functionality, including regenerating the underlying Resources.Management SDK against a newer DeploymentStacks API version and adding new cmdlets/models to surface What-If results.

Changes:

Export new Deployment Stack What-If cmdlets in Az.Resources.psd1.
Regenerate Resources.Management.Sdk for DeploymentStacks 2025-07-01, adding new What-If models/operations and updating several existing models/headers.
Add new ResourceManager cmdlets and PowerShell models/formatting helpers to execute and display Deployment Stack What-If results.

Reviewed changes

Copilot reviewed 16 out of 81 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/Resources/Resources/Az.Resources.psd1	Exports new Deployment Stack What-If cmdlets.
src/Resources/Resources.Management.Sdk/README.md	Updates AutoRest tag/commit and adds tag config for deploymentstacks `2025-07`.
src/Resources/Resources.Management.Sdk/Generated/Models/ResourceReferenceExtended.cs	Regenerated model: adds extensible resource fields and validation.
src/Resources/Resources.Management.Sdk/Generated/Models/ResourceReference.cs	Regenerated model: adds extensible resource fields and validation.
src/Resources/Resources.Management.Sdk/Generated/Models/Resource.cs	Regenerated common ARM resource model shape (now includes `systemData`).
src/Resources/Resources.Management.Sdk/Generated/Models/ProxyResource.cs	Regenerated proxy resource base type (now derives from `Resource`).
src/Resources/Resources.Management.Sdk/Generated/Models/ManagedResourceReference.cs	Regenerated model: adds extensible identifiers and updated denyStatus values.
src/Resources/Resources.Management.Sdk/Generated/Models/ErrorResponse.cs	Regenerated error response model (now wraps `ErrorDetail`).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResultsAtSubscriptionWhatIfHeaders.cs	New generated headers type for subscription-scope What-If.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResultsAtSubscriptionCreateOrUpdateHeaders.cs	New generated headers type for subscription-scope create/update.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResultsAtResourceGroupWhatIfHeaders.cs	New generated headers type for RG-scope What-If.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResultsAtResourceGroupCreateOrUpdateHeaders.cs	New generated headers type for RG-scope create/update.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResultsAtManagementGroupWhatIfHeaders.cs	New generated headers type for MG-scope What-If.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResultsAtManagementGroupCreateOrUpdateHeaders.cs	New generated headers type for MG-scope create/update.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResultProperties.cs	New generated What-If result properties model.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResult.cs	New generated What-If result resource model.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResourceChangeResourceConfigurationChanges.cs	New generated property-level configuration change model.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResourceChangeManagementStatusChange.cs	New generated management status change model.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResourceChangeDenyStatusChange.cs	New generated deny status change model.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfResourceChange.cs	New generated resource change model.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfPropertyChangeType.cs	New generated constants for What-If property change types.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfPropertyChange.cs	New generated model for nested property deltas.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfChangeType.cs	New generated constants for What-If change types.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfChangeDeploymentScopeChange.cs	New generated model for predicted deployment scope changes.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfChangeDenySettingsChange.cs	New generated model for predicted denySettings changes.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfChangeCertainty.cs	New generated constants for prediction certainty.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksWhatIfChange.cs	New generated model containing predicted changes.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksValidateStackAtSubscriptionHeaders.cs	Regenerated validate headers (Retry-After now `int?`).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksValidateStackAtResourceGroupHeaders.cs	Regenerated validate headers (Retry-After now `int?`).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksValidateStackAtManagementGroupHeaders.cs	Regenerated validate headers (Retry-After now `int?`).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksResourcesWithoutDeleteSupportEnum.cs	New generated enum constants for delete-unsupported resources behavior.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksManagementStatus.cs	New generated enum constants for management status.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksDiagnosticLevel.cs	New generated enum constants for diagnostic level.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksDiagnostic.cs	New generated diagnostic model.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksDeleteDetachEnum.cs	Regenerated enum constants with improved docs.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksDeleteAtSubscriptionHeaders.cs	Regenerated delete headers (adds Retry-After).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksDeleteAtResourceGroupHeaders.cs	Regenerated delete headers (adds Retry-After).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksDeleteAtManagementGroupHeaders.cs	Regenerated delete headers (adds Retry-After).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksCreateOrUpdateAtSubscriptionHeaders.cs	New generated create/update headers for subscription scope.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksCreateOrUpdateAtResourceGroupHeaders.cs	New generated create/update headers for RG scope.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStacksCreateOrUpdateAtManagementGroupHeaders.cs	New generated create/update headers for MG scope.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStackValidateProperties.cs	Regenerated validate properties (adds extensions + validation level).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStackTemplateDefinition.cs	Regenerated template type (`IDictionary<string, object>`).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStackProvisioningState.cs	Regenerated provisioning states (adds initializing/running + docs).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentStackProperties.cs	Regenerated stack properties (adds extension/external inputs + new fields).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentParameter.cs	Regenerated parameter model (adds `expression`).
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentExternalInputDefinition.cs	New generated model for external input definitions.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentExternalInput.cs	New generated model for external inputs.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentExtensionConfigItem.cs	New generated model for extension config items.
src/Resources/Resources.Management.Sdk/Generated/Models/DeploymentExtension.cs	New generated model for extension usage details.
src/Resources/Resources.Management.Sdk/Generated/Models/DenyStatusMode.cs	Regenerated deny status mode constants (adds `unknown`).
src/Resources/Resources.Management.Sdk/Generated/Models/ActionOnUnmanage.cs	Regenerated action model (adds `resourcesWithoutDeleteSupport`).
src/Resources/Resources.Management.Sdk/Generated/IDeploymentStacksWhatIfResultsAtSubscriptionOperations.cs	New generated operations interface for subscription-scope What-If results.
src/Resources/Resources.Management.Sdk/Generated/IDeploymentStacksWhatIfResultsAtResourceGroupOperations.cs	New generated operations interface for RG-scope What-If results.
src/Resources/Resources.Management.Sdk/Generated/IDeploymentStacksWhatIfResultsAtManagementGroupOperations.cs	New generated operations interface for MG-scope What-If results.
src/Resources/Resources.Management.Sdk/Generated/IDeploymentStacksClient.cs	Regenerated client interface (SubscriptionId is Guid; adds What-If ops groups).
src/Resources/Resources.Management.Sdk/Generated/DeploymentStacksWhatIfResultsAtSubscriptionOperationsExtensions.cs	New generated extension helpers for subscription-scope What-If ops.
src/Resources/Resources.Management.Sdk/Generated/DeploymentStacksWhatIfResultsAtResourceGroupOperationsExtensions.cs	New generated extension helpers for RG-scope What-If ops.
src/Resources/Resources.Management.Sdk/Generated/DeploymentStacksWhatIfResultsAtManagementGroupOperationsExtensions.cs	New generated extension helpers for MG-scope What-If ops.
src/Resources/Resources.Management.Sdk/Generated/DeploymentStacksClient.cs	Regenerated client (ApiVersion `2025-07-01`; wires What-If ops).
src/Resources/ResourceManager/SdkModels/Deployments/PSDeploymentStackWhatIfResult.cs	New PowerShell-facing What-If result model + nested DTOs.
src/Resources/ResourceManager/SdkModels/Deployments/PSDeploymentStackWhatIfParameters.cs	New parameter DTO used to build/route What-If requests.
src/Resources/ResourceManager/SdkModels/DeploymentStacks/PSDenySettingsMode.cs	Moves enum into `SdkModels.DeploymentStacks` namespace.
src/Resources/ResourceManager/ResourceManager.csproj	Adds DeploymentStacks track2 package and updates Azure.Core.
src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzSubscriptionDeploymentStackWhatIf.cs	New cmdlet for subscription-scope deployment stack What-If.
src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzResourceGroupDeploymentStackWhatIf.cs	New cmdlet for RG-scope deployment stack What-If.
src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzManagementGroupDeploymentStackWhatIf.cs	New cmdlet for MG-scope deployment stack What-If.
src/Resources/ResourceManager/Implementation/CmdletBase/DeploymentStacksCmdletBase.cs	Minor update to imports.
src/Resources/ResourceManager/Implementation/CmdletBase/DeploymentStackWhatIfCmdlet.cs	New cmdlet base handling status output + invoking SDK client What-If.
src/Resources/ResourceManager/Formatters/ColoredStringBuilder.cs	Adds insertion/indent helpers and new newline utilities.
src/Resources/ResourceManager/Formatters/Color.cs	Adds Cyan ANSI color constant.

Comments suppressed due to low confidence (1)

src/Resources/Resources.Management.Sdk/README.md:180

The README says the directive is a "Temporary override to make subscription id GUID a string", but the generated client now uses System.Guid SubscriptionId. This makes the comment misleading; either update the comment to reflect the current intent (e.g., keep GUID typing) or adjust/remove the directive if string typing is still required.

Copilot · 2026-03-26T06:05:47Z

...es/ResourceManager/Implementation/DeploymentStacks/GetAzSubscriptionDeploymentStackWhatIf.cs

+    /// <summary>
+    /// Cmdlet to preview changes for a Subscription Deployment Stack.
+    /// </summary>
+    [Cmdlet("Get", AzureRMConstants.AzureRMPrefix + "SubscriptionDeploymentStackWhatIf",
+        DefaultParameterSetName = ParameterlessTemplateFileParameterSetName)]
+    [OutputType(typeof(PSDeploymentStackWhatIfResult))]
+    public class GetAzSubscriptionDeploymentStackWhatIf : DeploymentStackWhatIfCmdlet
+    {
+        #region Cmdlet Parameters
+
+        [Alias("StackName")]
+        [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The name of the DeploymentStack to preview changes for.")]
+        [ValidateNotNullOrEmpty]
+        public string Name { get; set; }
+
+        [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The location to store deployment data.")]
+        [ValidateNotNullOrEmpty]
+        public string Location { get; set; }
+
+        [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Description for the stack.")]
+        public string Description { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "The scope for the deployment stack. Determines where managed resources can be deployed.")]
+        public string DeploymentScope { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "Action to take on resources that become unmanaged. Possible values include: " +
+            "'detachAll', 'deleteResources', and 'deleteAll'.")]
+        public PSActionOnUnmanage ActionOnUnmanage { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "Mode for DenySettings. Possible values include: 'denyDelete', 'denyWriteAndDelete', and 'none'.")]
+        public PSDenySettingsMode DenySettingsMode { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "List of AAD principal IDs excluded from the lock. Up to 5 principals are permitted.")]
+        public string[] DenySettingsExcludedPrincipal { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "List of role-based management operations excluded from the denySettings. Up to 200 actions are permitted.")]
+        public string[] DenySettingsExcludedAction { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "Apply to child scopes.")]
+        public SwitchParameter DenySettingsApplyToChildScopes { get; set; }
+
+        #endregion
+
+        #region Cmdlet Implementation
+
+        protected override PSDeploymentStackWhatIfParameters BuildWhatIfParameters()
+        {
+            var shouldDeleteResources = (ActionOnUnmanage is PSActionOnUnmanage.DeleteAll || ActionOnUnmanage is PSActionOnUnmanage.DeleteResources);
+            var shouldDeleteResourceGroups = (ActionOnUnmanage is PSActionOnUnmanage.DeleteAll);
+            var shouldDeleteManagementGroups = (ActionOnUnmanage is PSActionOnUnmanage.DeleteAll);
+
+            return new PSDeploymentStackWhatIfParameters
+            {
+                StackName = Name,
+                Location = Location,
+                TemplateFile = TemplateFile,
+                TemplateUri = !string.IsNullOrEmpty(protectedTemplateUri) ? protectedTemplateUri : TemplateUri,
+                TemplateSpecId = TemplateSpecId,
+                TemplateObject = TemplateObject,
+                TemplateParameterUri = TemplateParameterUri,
+                TemplateParameterObject = GetTemplateParameterObject(),
+                Description = Description,
+                DeploymentScope = DeploymentScope,
+                ResourcesCleanupAction = shouldDeleteResources ? "delete" : "detach",
+                ResourceGroupsCleanupAction = shouldDeleteResourceGroups ? "delete" : "detach",
+                ManagementGroupsCleanupAction = shouldDeleteManagementGroups ? "delete" : "detach",
+                DenySettingsMode = DenySettingsMode != 0 ? DenySettingsMode.ToString() : null,
+                DenySettingsExcludedPrincipals = DenySettingsExcludedPrincipal,
+                DenySettingsExcludedActions = DenySettingsExcludedAction,
+                DenySettingsApplyToChildScopes = DenySettingsApplyToChildScopes.IsPresent
+            };
+        }
+
+        #endregion
+    }
+}


New Deployment Stack What-If cmdlets are introduced here, but there don’t appear to be corresponding scenario/unit tests covering them. Please add test coverage (e.g., new scenario tests in src/Resources/Resources.Test/ScenarioTests plus test scripts) to validate the What-If request construction and basic success/error flows at subscription/resource group/management group scope.

src/Resources/Resources/Az.Resources.psd1

src/Resources/Resources.Management.Sdk/Generated/Models/ErrorResponse.cs

src/Resources/ResourceManager/Implementation/CmdletBase/DeploymentStacksCmdletBase.cs

Copilot · 2026-03-26T06:05:48Z

src/Resources/ResourceManager/Formatters/ColoredStringBuilder.cs

+                this.Insert(index, color.ToString());
+            }
+            this.Insert(index, value + Environment.NewLine);
+            if (color != Color.Reset)
+            {
+                this.Insert(index, Color.Reset.ToString());


InsertLine inserts multiple values at the same index, but StringBuilder.Insert pushes existing content to the right. With the current order (color -> text -> reset), the final output becomes reset -> text -> color, which breaks the intended ANSI coloring. Insert in reverse order (reset, then text, then color) or adjust indices so the final sequence is color + text + reset.

Suggested change

this.Insert(index, color.ToString());

}

this.Insert(index, value + Environment.NewLine);

if (color != Color.Reset)

{

this.Insert(index, Color.Reset.ToString());

// Insert reset first so it ends up after the text once all inserts are applied.

this.Insert(index, Color.Reset.ToString());

}

// Insert the text next so it ends up between the color and reset codes.

this.Insert(index, value + Environment.NewLine);

if (color != Color.Reset)

{

// Insert the color code last so it appears before the text.

this.Insert(index, color.ToString());

NoriZC · 2026-03-26T06:08:31Z

/azp run

azure-pipelines · 2026-03-26T06:08:48Z

Azure Pipelines successfully started running 3 pipeline(s).

NoriZC · 2026-03-26T06:38:07Z

/azp run

azure-pipelines · 2026-03-26T06:38:22Z

Azure Pipelines successfully started running 3 pipeline(s).

This commit implements -WhatIf parameter support for all Deployment Stack cmdlets (New/Set) across all scopes (ResourceGroup, Subscription, ManagementGroup). Key changes: - Added WhatIf handling to New-AzResourceGroupDeploymentStack - Added WhatIf handling to Set-AzResourceGroupDeploymentStack - Added WhatIf handling to New-AzSubscriptionDeploymentStack - Added WhatIf handling to Set-AzSubscriptionDeploymentStack - Added WhatIf handling to New-AzManagementGroupDeploymentStack Implementation details: - DeploymentStacksSdkClient: Updated WhatIf methods to use polling approach instead of separate WhatIf API call that returns BadRequest - Resources.format.ps1xml: Added custom view for PSDeploymentStackWhatIfResult to display formatted output by default (matching Azure CLI) - Error handling: Gracefully handles scenarios where WhatIf API is not available Output format matches Azure CLI with: - Color-coded change symbols (+ Create, ~ Modify, - Delete, v Detach, = NoChange) - Legend explaining symbols - Stack property changes (DeploymentScope, DenySettings) - Managed resource changes with before/after states - Management status transitions - Deletion summaries The formatter (DeploymentStackWhatIfFormatter) was already present and is now properly integrated via the custom format view.

Includes: * Quick start test script with automated checks * Comprehensive test guide with all scenarios * Test checklist for testers to fill out * Template files for different test scenarios * Setup instructions and prerequisites

Copilot

Pull request overview

Copilot reviewed 28 out of 93 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-27T16:19:00Z

src/Resources/ResourceManager/Formatters/ColoredStringBuilder.cs

+
+            for (int i = currentText.Length - 1; i >= 0 && currentText[i] == '\n'; i--)
+            {
+                existingNewlines++;


EnsureNumNewLines counts only consecutive '\n' characters at the end of the buffer. When the buffer contains Windows newlines ("\r\n" from AppendLine/Environment.NewLine), the trailing characters are not consecutive '\n', so this undercounts existing newlines and may append extra blank lines. Consider counting trailing newline sequences in an OS-agnostic way (e.g., trim trailing "\r"/"\n" and compute how many newline sequences are present, or iterate from the end handling "\r\n" as one).

Suggested change

for (int i = currentText.Length - 1; i >= 0 && currentText[i] == '\n'; i--)

{

existingNewlines++;

int index = currentText.Length - 1;

// Count trailing newline sequences in an OS-agnostic way:

// - Treat "\r\n" as a single newline

// - Also handle lone '\n' and lone '\r'

while (index >= 0)

{

if (currentText[index] == '\n')

{

existingNewlines++;

index--;

// Consume preceding '\r' if this is a Windows newline sequence "\r\n"

if (index >= 0 && currentText[index] == '\r')

{

index--;

}

}

else if (currentText[index] == '\r')

{

existingNewlines++;

index--;

}

else

{

break;

}

Copilot · 2026-03-27T16:19:01Z

src/Resources/Resources.Management.Sdk/Generated/IDeploymentStacksClient.cs

        /// <summary>
-        /// The ID of the target subscription.
+        /// The ID of the target subscription. The value must be an UUID.
        /// </summary>
-        string SubscriptionId { get; set;}
+        System.Guid SubscriptionId { get; set;}


DeploymentStacksClient/IDeploymentStacksClient now exposes SubscriptionId as System.Guid, while other generated ARM clients in this repo use string SubscriptionId. This inconsistency can break shared client-factory code that sets SubscriptionId from Azure context (usually a string) and makes this client harder to use consistently. Consider keeping SubscriptionId as string (via swagger/directive) or ensure the factory path explicitly parses/sets the Guid and all call sites are updated accordingly.

Copilot · 2026-03-27T16:19:01Z

src/Resources/Resources.Management.Sdk/README.md

+# Temporary override to make subscription id GUID a string.
+directive:
+  - from: deploymentStacks.json
+    where: $
+    transform: $ = $.replace(/common-types\/resource-management\/v5\/types.json#\/parameters\/SubscriptionIdParameter/g, 'common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter');
+```


The README says the directive is a temporary override to make SubscriptionId a string, but the generated DeploymentStacksClient/IDeploymentStacksClient in this PR uses System.Guid for SubscriptionId. Either the directive/comment is no longer accurate, or the override isn’t being applied as intended. Please reconcile this so the generation docs reflect the actual output (or fix the directive so SubscriptionId becomes string if that’s required).

NoriZC · 2026-03-27T16:38:30Z

/azp run

azure-pipelines · 2026-03-27T16:38:46Z

Azure Pipelines successfully started running 3 pipeline(s).

This reverts commit 2eea4e2.

NoriZC · 2026-03-27T17:08:16Z

/azp run

azure-pipelines · 2026-03-27T17:08:32Z

Azure Pipelines successfully started running 3 pipeline(s).

NoriZC · 2026-03-27T18:38:25Z

/azp run

azure-pipelines · 2026-03-27T18:38:43Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 32 out of 97 changed files in this pull request and generated 7 comments.

Copilot · 2026-03-27T18:49:21Z

...esources/ResourceManager/Implementation/DeploymentStacks/NewAzSubscriptionDeploymentStack.cs

+                // Handle WhatIf scenario
+                if (MyInvocation.BoundParameters.ContainsKey("WhatIf") && ((SwitchParameter)MyInvocation.BoundParameters["WhatIf"]).ToBool())
+                {
+                    var whatIfResult = DeploymentStacksSdkClient.ExecuteSubscriptionDeploymentStackWhatIf(
+                        deploymentStackName: Name,
+                        location: Location,
+                        templateFile: TemplateFile,
+                        templateUri: !string.IsNullOrEmpty(protectedTemplateUri) ? protectedTemplateUri : TemplateUri,
+                        templateSpec: TemplateSpecId,
+                        templateObject: TemplateObject,
+                        parameterUri: TemplateParameterUri,
+                        parameters: GetTemplateParameterObject(),
+                        description: Description,
+                        resourcesCleanupAction: shouldDeleteResources ? "delete" : "detach",
+                        resourceGroupsCleanupAction: shouldDeleteResourceGroups ? "delete" : "detach",
+                        managementGroupsCleanupAction: shouldDeleteManagementGroups ? "delete" : "detach",
+                        deploymentScope: deploymentScope,
+                        denySettingsMode: DenySettingsMode.ToString(),
+                        denySettingsExcludedPrincipals: DenySettingsExcludedPrincipal,
+                        denySettingsExcludedActions: DenySettingsExcludedAction,
+                        denySettingsApplyToChildScopes: DenySettingsApplyToChildScopes.IsPresent,
+                        bypassStackOutOfSyncError: BypassStackOutOfSyncError.IsPresent
+                    );
+
+                    WriteObject(whatIfResult);
+                    return;


In the -WhatIf branch this cmdlet returns whatIfResult (a PSDeploymentStackWhatIfResult), but the cmdlet’s declared OutputType is PSDeploymentStack. This mismatch affects help and downstream tooling. Consider updating the OutputType to include the What-If result type (or separating into a dedicated cmdlet/parameter).

Copilot · 2026-03-27T18:49:22Z

...esources/ResourceManager/Implementation/DeploymentStacks/SetAzSubscriptionDeploymentStack.cs

+                // Handle WhatIf scenario
+                if (MyInvocation.BoundParameters.ContainsKey("WhatIf") && ((SwitchParameter)MyInvocation.BoundParameters["WhatIf"]).ToBool())
+                {
+                    var whatIfResult = DeploymentStacksSdkClient.ExecuteSubscriptionDeploymentStackWhatIf(
+                        deploymentStackName: Name,
+                        location: Location,
+                        templateFile: TemplateFile,
+                        templateUri: !string.IsNullOrEmpty(protectedTemplateUri) ? protectedTemplateUri : TemplateUri,
+                        templateSpec: TemplateSpecId,
+                        templateObject: TemplateObject,
+                        parameterUri: TemplateParameterUri,
+                        parameters: GetTemplateParameterObject(),
+                        description: Description,
+                        resourcesCleanupAction: shouldDeleteResources ? "delete" : "detach",
+                        resourceGroupsCleanupAction: shouldDeleteResourceGroups ? "delete" : "detach",
+                        managementGroupsCleanupAction: shouldDeleteManagementGroups ? "delete" : "detach",
+                        deploymentScope: deploymentScope,
+                        denySettingsMode: DenySettingsMode.ToString(),
+                        denySettingsExcludedPrincipals: DenySettingsExcludedPrincipal,
+                        denySettingsExcludedActions: DenySettingsExcludedAction,
+                        denySettingsApplyToChildScopes: DenySettingsApplyToChildScopes.IsPresent,
+                        bypassStackOutOfSyncError: BypassStackOutOfSyncError.IsPresent
+                    );
+
+                    WriteObject(whatIfResult);
+                    return;


In the -WhatIf branch this cmdlet returns whatIfResult (a PSDeploymentStackWhatIfResult), but the cmdlet’s declared OutputType is PSDeploymentStack. This mismatch affects help and downstream tooling. Consider updating the OutputType to include the What-If result type (or separating into a dedicated cmdlet/parameter).

Copilot · 2026-03-27T18:49:22Z

bugbash-templates/SetupPowerShellBugBash.ps1

+if ($psVersion.Major -lt 7) {
+    Write-Host "? PowerShell 7+ required. You have: $psVersion" -ForegroundColor Red
+    Write-Host "   Download from: https://aka.ms/powershell" -ForegroundColor Yellow
+    exit 1
+} else {
+    Write-Host "? PowerShell version: $psVersion" -ForegroundColor Green
+}
+
+# Check .NET SDK
+try {


This script hard-requires PowerShell 7+ (if ($psVersion.Major -lt 7) { ... exit 1 }) but it lives outside the repository tooling locations (/tools/, pipelines). Either move these bug bash scripts under a tooling directory, or make them PowerShell 5.1-compatible; at minimum, add #Requires -Version 7.0 so the requirement is enforced by PowerShell consistently.

Suggested change

if ($psVersion.Major -lt 7) {

Write-Host "? PowerShell 7+ required. You have: $psVersion" -ForegroundColor Red

Write-Host " Download from: https://aka.ms/powershell" -ForegroundColor Yellow

exit 1

} else {

Write-Host "? PowerShell version: $psVersion" -ForegroundColor Green

}

# Check .NET SDK

try {

Write-Host "? PowerShell version: $psVersion" -ForegroundColor Green

# Note: This script is intended to work on PowerShell 5.1+.

# PowerShell 7+ is recommended for best cross-platform support, but not required.

# Check .NET SDK

try {

try {

Copilot · 2026-03-27T18:49:23Z

src/Resources/Resources.Management.Sdk/Generated/DeploymentStacksClient.cs

+        /// The ID of the target subscription. The value must be an UUID.
        /// </summary>
-        public string SubscriptionId { get; set;}
+        public System.Guid SubscriptionId { get; set;}


DeploymentStacksClient.SubscriptionId is now System.Guid. The Az client factory path typically sets SubscriptionId using the context subscription ID string; if this property isn’t set correctly, requests will be sent with an empty/default subscriptionId. Recommend reverting to string for compatibility or ensuring the factory reliably converts/assigns the subscription id value.

Suggested change

public System.Guid SubscriptionId { get; set;}

public string SubscriptionId { get; set;}

Copilot · 2026-03-27T18:49:23Z

...sources/ResourceManager/Implementation/DeploymentStacks/NewAzResourceGroupDeploymentStack.cs

+                // Handle WhatIf scenario
+                if (MyInvocation.BoundParameters.ContainsKey("WhatIf") && ((SwitchParameter)MyInvocation.BoundParameters["WhatIf"]).ToBool())
+                {
+                    var whatIfResult = DeploymentStacksSdkClient.ExecuteResourceGroupDeploymentStackWhatIf(
+                        deploymentStackName: Name,
+                        resourceGroupName: ResourceGroupName,
+                        templateFile: TemplateFile,
+                        templateUri: !string.IsNullOrEmpty(protectedTemplateUri) ? protectedTemplateUri : TemplateUri,
+                        templateSpec: TemplateSpecId,
+                        templateObject: TemplateObject,
+                        parameterUri: TemplateParameterUri,
+                        parameters: GetTemplateParameterObject(),
+                        description: Description,
+                        resourcesCleanupAction: shouldDeleteResources ? "delete" : "detach",
+                        resourceGroupsCleanupAction: shouldDeleteResourceGroups ? "delete" : "detach",
+                        managementGroupsCleanupAction: shouldDeleteManagementGroups ? "delete" : "detach",
+                        denySettingsMode: DenySettingsMode.ToString(),
+                        denySettingsExcludedPrincipals: DenySettingsExcludedPrincipal,
+                        denySettingsExcludedActions: DenySettingsExcludedAction,
+                        denySettingsApplyToChildScopes: DenySettingsApplyToChildScopes.IsPresent,
+                        bypassStackOutOfSyncError: BypassStackOutOfSyncError.IsPresent
+                    );
+
+                    WriteObject(whatIfResult);
+                    return;


In the -WhatIf branch this cmdlet returns whatIfResult (a PSDeploymentStackWhatIfResult), but the cmdlet’s declared OutputType is PSDeploymentStack. This mismatch affects help and downstream tooling. Consider updating the OutputType to include the What-If result type (or separating into a dedicated cmdlet/parameter).

Copilot · 2026-03-27T18:49:23Z

...sources/ResourceManager/Implementation/DeploymentStacks/SetAzResourceGroupDeploymentStack.cs

+                // Handle WhatIf scenario
+                if (MyInvocation.BoundParameters.ContainsKey("WhatIf") && ((SwitchParameter)MyInvocation.BoundParameters["WhatIf"]).ToBool())
+                {
+                    var whatIfResult = DeploymentStacksSdkClient.ExecuteResourceGroupDeploymentStackWhatIf(
+                        deploymentStackName: Name,
+                        resourceGroupName: ResourceGroupName,
+                        templateFile: TemplateFile,
+                        templateUri: !string.IsNullOrEmpty(protectedTemplateUri) ? protectedTemplateUri : TemplateUri,
+                        templateSpec: TemplateSpecId,
+                        templateObject: TemplateObject,
+                        parameterUri: TemplateParameterUri,
+                        parameters: GetTemplateParameterObject(),
+                        description: Description,
+                        resourcesCleanupAction: shouldDeleteResources ? "delete" : "detach",
+                        resourceGroupsCleanupAction: shouldDeleteResourceGroups ? "delete" : "detach",
+                        managementGroupsCleanupAction: shouldDeleteManagementGroups ? "delete" : "detach",
+                        denySettingsMode: DenySettingsMode.ToString(),
+                        denySettingsExcludedPrincipals: DenySettingsExcludedPrincipal,
+                        denySettingsExcludedActions: DenySettingsExcludedAction,
+                        denySettingsApplyToChildScopes: DenySettingsApplyToChildScopes.IsPresent,
+                        bypassStackOutOfSyncError: BypassStackOutOfSyncError.IsPresent
+                    );
+
+                    WriteObject(whatIfResult);
+                    return;


In the -WhatIf branch this cmdlet returns whatIfResult (a PSDeploymentStackWhatIfResult), but the cmdlet’s declared OutputType is PSDeploymentStack. This mismatch affects help and downstream tooling. Consider updating the OutputType to include the What-If result type (or separating into a dedicated cmdlet/parameter).

Copilot · 2026-03-27T18:49:23Z

bugbash-templates/README.md

+   git clone https://github.com/anamikapan11/azure-powershell
+   cd azure-powershell
+   git checkout anapandey/pwcmdlet


The bug bash docs hardcode a personal fork URL and branch name (e.g., github.com/anamikapan11/azure-powershell, anapandey/pwcmdlet). After this PR merges, those instructions will be incorrect for readers/testers. Please update to reference the canonical repo/branch (or describe how to check out the PR branch) and remove fixed commit IDs where possible.

Suggested change

git clone https://github.com/anamikapan11/azure-powershell

cd azure-powershell

git checkout anapandey/pwcmdlet

git clone https://github.com/Azure/azure-powershell

cd azure-powershell

git checkout <branch-name>

NoriZC · 2026-03-27T20:08:20Z

/azp run

azure-pipelines · 2026-03-27T20:08:38Z

Azure Pipelines successfully started running 3 pipeline(s).

anamikapan11 added 2 commits March 25, 2026 22:56

powershell changes for what if

c40202f

added generated files and changes for what if

39c297d

Copilot AI review requested due to automatic review settings March 26, 2026 05:57

anamikapan11 changed the title ~~Anapandey/pwcmdlet~~ Do not review-powershell cmdlet Mar 26, 2026

Copilot started reviewing on behalf of anamikapan11 March 26, 2026 05:59 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

added suggested fixes

30a60a4

Copilot AI review requested due to automatic review settings March 27, 2026 16:09

Copilot started reviewing on behalf of anamikapan11 March 27, 2026 16:14 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Revert "Add bug bash materials for Deployment Stacks WhatIf testing"

907695d

This reverts commit 2eea4e2.

anamikapan11 added 2 commits March 27, 2026 11:32

Add setup script and parameter files for bug bash package

cc29907

Restore all bug bash materials with complete package

d9f5f15

Copilot AI review requested due to automatic review settings March 27, 2026 18:35

Copilot started reviewing on behalf of anamikapan11 March 27, 2026 18:42 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Fix quick-start-test.ps1 to work from any directory

1af6c26

-            for (int i = currentText.Length - 1; i >= 0 && currentText[i] == '\n'; i--)
-            {
-                existingNewlines++;
+            int index = currentText.Length - 1;
+            // Count trailing newline sequences in an OS-agnostic way:
+            // - Treat "\r\n" as a single newline
+            // - Also handle lone '\n' and lone '\r'
+            while (index >= 0)
+            {
+                if (currentText[index] == '\n')
+                {
+                    existingNewlines++;
+                    index--;
+                    // Consume preceding '\r' if this is a Windows newline sequence "\r\n"
+                    if (index >= 0 && currentText[index] == '\r')
+                    {
+                        index--;
+                    }
+                }
+                else if (currentText[index] == '\r')
+                {
+                    existingNewlines++;
+                    index--;
+                }
+                else
+                {
+                    break;
+                }

	public System.Guid SubscriptionId { get; set;}
	public string SubscriptionId { get; set;}

Conversation

anamikapan11 commented Mar 26, 2026

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

NoriZC commented Mar 26, 2026

Uh oh!

azure-pipelines bot commented Mar 26, 2026

Uh oh!

NoriZC commented Mar 26, 2026

Uh oh!

azure-pipelines bot commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

NoriZC commented Mar 27, 2026

Uh oh!

azure-pipelines bot commented Mar 27, 2026

Uh oh!

NoriZC commented Mar 27, 2026

Uh oh!

azure-pipelines bot commented Mar 27, 2026

Uh oh!

NoriZC commented Mar 27, 2026

Uh oh!

azure-pipelines bot commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

NoriZC commented Mar 27, 2026