Skip to content

Do not review - powershell changes for what if #29291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anamikapan11 wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Do not review - powershell changes for what if #29291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b2ef0f9
powershell changes for what if
anamikapan11 Mar 19, 2026
a463a46
Add new Az.ComputeLimit module for shared compute limits (#29266)
deepnandu Mar 20, 2026
34d8d13
Avoid sending status email if no error (#29284)
vidai-msft Mar 20, 2026
a17f4be
Fix placeholder issues (#29283)
vidai-msft Mar 20, 2026
8b82f24
[skip ci] Archive c0cb41f8f9e650c5b0f9a00278ee4aa60976db61 (#29286)
azure-powershell-bot Mar 20, 2026
b1d2cd8
[ComputeLimit] Fix oob failure (#29288)
NoriZC Mar 20, 2026
646c3e2
Az.FileShares - Add Tests for fileshares (#29256)
ankushbindlish2 Mar 22, 2026
867e2b5
Update Az.StandbyPool to API version 2025-10-01 (#29278)
carlosh-msft2025 Mar 23, 2026
98857f7
ComputeLimit OOB Release (#29289)
azure-powershell-bot Mar 23, 2026
9d7270b
[skip ci] Archive f62bc72858b92b3bb5ed3d876c8574a2a4664ca0 (#29296)
azure-powershell-bot Mar 23, 2026
ad97d7c
Sync resourceManagement.yml according To ADO Wiki Page - Service Cont…
azure-powershell-bot Mar 24, 2026
76d6d88
Fix Update-AzSentinelIncident docs: clarify required params and add p…
coder999999999 Mar 24, 2026
0a62a12
Fileshares testing update (#29307)
ankushbindlish2 Mar 24, 2026
d0c04bc
[skip ci] Archive 1b79ce04250923261d1237a8c1b4af994e8a8059 (#29306)
azure-powershell-bot Mar 24, 2026
e208b8e
added generated files and changes for what if
anamikapan11 Mar 26, 2026
6fa41a4
Merge branch 'Azure:main' into anapandey/cmdlet
anamikapan11 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
761 changes: 761 additions & 0 deletions DEPLOYMENT_STACKS_WHATIF_MODELS_GUIDE.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/Resources/ResourceManager/Formatters/Color.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public class Color : IEquatable<Color>

public static Color Blue { get; } = new Color($"{Esc}[38;5;39m");

public static Color Cyan { get; } = new Color($"{Esc}[38;5;51m");

public static Color Gray { get; } = new Color($"{Esc}[38;5;246m");

public static Color Reset { get; } = new Color($"{Esc}[0m");
Expand Down
78 changes: 76 additions & 2 deletions src/Resources/ResourceManager/Formatters/ColoredStringBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public class ColoredStringBuilder

private readonly Stack<Color> colorStack = new Stack<Color>();

private readonly List<string> indentStack = new List<string>();

public override string ToString()
{
return stringBuilder.ToString();
Expand Down Expand Up @@ -89,6 +91,78 @@ public AnsiColorScope NewColorScope(Color color)
return new AnsiColorScope(this, color);
}

public void Insert(int index, string value)
{
if (index >= 0 && index <= this.stringBuilder.Length)
{
this.stringBuilder.Insert(index, value);
}
}

public void InsertLine(int index, string value, Color color)
{
if (color != Color.Reset)
{
this.Insert(index, color.ToString());
}
this.Insert(index, value + Environment.NewLine);
if (color != Color.Reset)
{
this.Insert(index, Color.Reset.ToString());
}
Comment on lines +104 to +112
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InsertLine inserts multiple strings at the same index, which reverses the intended order (the reset/color codes end up before the inserted line). This will corrupt ANSI coloring for inserted headers. Consider building the full colored line string once (color + value + newline + reset) and inserting it in a single StringBuilder.Insert, or adjust the indices so insertion order is correct.

Suggested change
if (color != Color.Reset)
{
this.Insert(index, color.ToString());
}
this.Insert(index, value + Environment.NewLine);
if (color != Color.Reset)
{
this.Insert(index, Color.Reset.ToString());
}
string line;
if (color != Color.Reset)
{
line = color.ToString() + value + Environment.NewLine + Color.Reset.ToString();
}
else
{
line = value + Environment.NewLine;
}
this.Insert(index, line);

Copilot uses AI. Check for mistakes.
}

public int GetCurrentIndex()
{
return this.stringBuilder.Length;
}

public void PushIndent(string indent)
{
this.indentStack.Add(indent);
}

public void PopIndent()
{
if (this.indentStack.Count > 0)
{
this.indentStack.RemoveAt(this.indentStack.Count - 1);
}
}
Comment on lines +120 to +131
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PushIndent/PopIndent maintain an indentStack, but none of the Append* methods apply the current indent when writing new lines. As a result, DeploymentStackWhatIfFormatter’s indentation calls have no effect. Please wire indentation into AppendLine/newline handling (or remove the indent stack if not intended).

Copilot uses AI. Check for mistakes.

public void EnsureNumNewLines(int numNewLines)
{
if (this.stringBuilder.Length == 0)
{
for (int i = 0; i < numNewLines; i++)
{
this.stringBuilder.AppendLine();
}
return;
}

string currentText = this.stringBuilder.ToString();
int existingNewlines = 0;

for (int i = currentText.Length - 1; i >= 0 && currentText[i] == '\n'; i--)
{
existingNewlines++;
Comment on lines +146 to +149
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnsureNumNewLines counts only trailing '\n' characters. With Windows line endings (\r\n), multiple trailing newlines will be undercounted because the loop stops when it hits the trailing '\r', causing extra blank lines to be appended. Consider counting Environment.NewLine sequences (or treating both '\r' and '\n' as newline terminators).

Suggested change
for (int i = currentText.Length - 1; i >= 0 && currentText[i] == '\n'; i--)
{
existingNewlines++;
int index = currentText.Length - 1;
// Count trailing newline sequences at the end of the current text.
// Treat '\n', '\r\n', and standalone '\r' as a single newline each.
while (index >= 0)
{
char c = currentText[index];
if (c == '\n')
{
existingNewlines++;
index--;
if (index >= 0 && currentText[index] == '\r')
{
index--;
}
}
else if (c == '\r')
{
existingNewlines++;
index--;
}
else
{
break;
}

Copilot uses AI. Check for mistakes.
}

int remainingNewlines = numNewLines - existingNewlines;
for (int i = 0; i < remainingNewlines; i++)
{
this.stringBuilder.AppendLine();
}
}

public void Clear()
{
this.stringBuilder.Clear();
this.colorStack.Clear();
this.indentStack.Clear();
}

private void PushColor(Color color)
{
this.colorStack.Push(color);
Expand All @@ -101,7 +175,7 @@ private void PopColor()
this.stringBuilder.Append(this.colorStack.Count > 0 ? this.colorStack.Peek() : Color.Reset);
}

public class AnsiColorScope: IDisposable
public class AnsiColorScope : IDisposable
{
private readonly ColoredStringBuilder builder;

Expand All @@ -117,4 +191,4 @@ public void Dispose()
}
}
}
}
}
Loading
Loading