MAINT set up GitHub Copilot CLI in devcontainer#1431
MAINT set up GitHub Copilot CLI in devcontainer#1431romanlutz wants to merge 9 commits intoAzure:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds GitHub Copilot tooling to the devcontainer so Copilot is available inside the containerized dev environment.
Changes:
- Install
@github/copilotglobally in the devcontainer image. - Add
github.copilotandgithub.copilot-chatto the devcontainer’s VS Code extension list. - Update
frontend/package-lock.json(includes a Rollup version change).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
frontend/package-lock.json |
Updates locked frontend dependencies (notably Rollup + platform-specific Rollup binaries). |
.devcontainer/devcontainer.json |
Adds Copilot and Copilot Chat extensions to the container’s VS Code setup. |
.devcontainer/Dockerfile |
Installs Copilot CLI via npm during devcontainer image build. |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
| "integrity": "sha512-e7jT4DxYvIDLk1ZHmU/m/mB19rex9sv0c2ftBtjSBv+kVM/902eh0fINUzD7UwLLNR+jU585GxUJ8/EBfAM5fw==", | ||
| "dev": true, | ||
| "license": "MIT", | ||
| "peer": true, | ||
| "dependencies": { | ||
| "@babel/code-frame": "^7.27.1", |
There was a problem hiding this comment.
frontend/package-lock.json has lockfile churn (multiple packages flipping the generated "peer": true metadata) without any corresponding package.json change. Unless you intended to update the lockfile format, it would be better to revert this to keep the PR focused and avoid noisy diffs/merge conflicts; if it is intended, please regenerate the lockfile in a single consistent npm version/environment and note the rationale in the PR.
Reset the lockfile to main and re-ran npm install to eliminate spurious metadata churn (libc fields, peer flag noise) that was introduced by a different npm version. The lockfile now has a minimal, consistent diff. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
force-pushed
the
romanlutz/devcontainer-gh-copilot-cli
branch
from
2118152 to
1138bda
Compare
frontend/package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/@types/aria-query/-/aria-query-5.0.4.tgz", | ||
| "integrity": "sha512-rfT93uj5s0PRL7EzccGMs3brplhcrghnDoV26NqKhCAS1hVo+WdNsPvE/yb6ilfr5hi2MEk6d5EWJTKdxg8jVw==", | ||
| "dev": true, | ||
| "license": "MIT" | ||
| "license": "MIT", | ||
| "peer": true |
There was a problem hiding this comment.
This PR is about devcontainer Copilot CLI setup, but frontend/package-lock.json is being regenerated with widespread metadata-only changes (e.g., toggling/relocating peer: true) without any corresponding frontend/package.json change. If this lockfile churn isn’t required for the devcontainer feature, please revert it to reduce merge conflicts/noise; if it is required, document what tool/version change necessitated re-locking.
| RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \ | ||
| && apt-get install -y nodejs \ | ||
| && npm install -g npm@latest \ | ||
| && npm install -g @github/copilot \ |
There was a problem hiding this comment.
npm install -g @github/copilot is unpinned, so the devcontainer image contents can change from build to build (and potentially break unexpectedly). Please pin @github/copilot to an explicit version (or otherwise make this deterministic, e.g., via a build arg) so container rebuilds are predictable.
| RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \ | |
| && apt-get install -y nodejs \ | |
| && npm install -g npm@latest \ | |
| && npm install -g @github/copilot \ | |
| ARG COPILOT_VERSION=1.0.0 | |
| RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \ | |
| && apt-get install -y nodejs \ | |
| && npm install -g npm@latest \ | |
| && npm install -g @github/copilot@${COPILOT_VERSION} \ |
| "orta.vscode-jest", | ||
| "github.copilot", | ||
| "github.copilot-chat" |
There was a problem hiding this comment.
PR title/description talk about adding the Copilot CLI, but this change installs the VS Code Copilot extensions (github.copilot, github.copilot-chat). If the intent is to add extensions (not the CLI), please align the PR title/description accordingly; if the intent is truly CLI usage, please add/verify the CLI installation and document how to invoke it inside the container.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GitHub Copilot CLI appears to be more convenient in many situations. This change adds it into our devcontainer so that it's available inside.
This can be used quite easily with the following button in the GitHub Copilot dropdown in VS Code
and just renders inline
which can be split to the right just like the GitHub Copilot Chat view.