-
Notifications
You must be signed in to change notification settings - Fork 684
FEAT analytics: analyze attack success rate with generic dimensions #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romanlutz
wants to merge
14
commits into
Azure:main
Choose a base branch
from
romanlutz:romanlutz/analytics_asr_by_generic_dimensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4400da5
Initial plan
Copilot 2b3c3c0
Add ASR reporting by converter type with tests
Copilot a7e1104
Fix redundant imports based on code review feedback
Copilot b43ea4d
Refactor tests and improve code clarity per review feedback
Copilot 2a47678
more generic approach to filtering
romanlutz a83fe76
fix: update type annotations and use class_name attribute
romanlutz 8e2cc4d
fix: use ComponentIdentifier instead of dict/ConverterIdentifier in t…
romanlutz 866599e
fix: ruff format
romanlutz 37731c3
Merge remote-tracking branch 'origin/main' into romanlutz/analytics_a…
romanlutz f3bd4f6
Merge remote-tracking branch 'origin/main' into romanlutz/analytics_a…
romanlutz 91160dd
Merge remote-tracking branch 'origin/main' into romanlutz/analytics_a…
romanlutz fee27f8
fix: use ComponentIdentifier instead of ConverterIdentifier and raw d…
romanlutz f24dff1
Merge remote-tracking branch 'origin/main' into romanlutz/analytics_a…
romanlutz ea847dc
Fix PERF401: use list comprehension for resolved_group_by
romanlutz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
1_result_analysisnotebook is added to_toc.ymlat the top level with no parent page or section, positioned between the scoring section and the memory section. By contrast, other notebooks like scoring (code/scoring/0_scoring) have a dedicated parent section entry. The analytics notebook should either have a parent analytics section page (e.g.,code/analytics/0_analytics) or be nested under an existing relevant section, rather than appearing as a standalone top-level entry without a parent section.