-
Notifications
You must be signed in to change notification settings - Fork 251
feat: install aznfs package on AzureLinux 3.0 #8085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andyzhangx
wants to merge
12
commits into
main
Choose a base branch
from
andyzhangx/install-aznfs-linux3-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2e1dfb1
feat: install aznfs package on AzureLinux 3.0
andyzhangx 6b047d1
fix: address hbeberman review comments for aznfs install
andyzhangx e40c8aa
feat: add aznfs RPM to components.json for version tracking
andyzhangx bca74c5
fix: use pre-downloaded aznfs RPM from VHD instead of downloading at …
andyzhangx 0d80632
fix: address review comments - use dnf_install, improve systemctl err…
andyzhangx c14d00a
fix: remove ubuntu and flatcar entries from aznfs in components.json
andyzhangx bbe5248
fix: use arch-aware RPM URL and move aznfs install after download loop
AndyZHYU a38dcdc
fix: simplify aznfswatchdog disable and import Microsoft RPM GPG key
AndyZHYU 24add77
use sort -V to deterministically pick newest aznfs RPM
andyzhangx 765e71f
fix: address review comments from djsly
andyzhangx a33bcb4
fix: remove duplicate installAznfsPkgFromPMC call after download loop
andyzhangx ddd74fa
resolve merge conflicts with main
andyzhangx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why arent we looking at tracking the versions with renovate ? when would this need to change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aznfs package is from PMC (packages.microsoft.com) not the AzureLinux repo, so renovate can't track it. The version is pinned with
<DO_NOT_UPDATE>tag and we'd bump it manually when a new version is available. We could add a custom renovate datasource later if this becomes a maintenance burden.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renovate support PMC, or I mean we could easily add support for the locaiton of this package
I'm just scared at one point we will loose track of the manual bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do it manually now since we need to verify the version before auto version bump. we need to make sure the version AB used is stable and won't break first. @djsly