Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new v1.35.0 tag entry for the azure-cloud-node-manager container image in the shared component manifest (parts/common/components.json), used for VHD build-time caching and related tooling.
Changes:
- Add
v1.35.0-1undermultiArchVersionsV2formcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:*. - Add
v1.35.0-windows-hpc-1underwindowsVersionsfor the same image.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Changes cached containers or packages on windows VHDsPlease get a Windows SIG member to approve. The following dif file shows any additions or deletions from what will be cached on windows VHDs organised by VHD type.
diff --git a/vhd_files/2022-containerd-gen2.txt b/vhd_files/2022-containerd-gen2.txt
index 920512b..70f313f 100644
--- a/vhd_files/2022-containerd-gen2.txt
+++ b/vhd_files/2022-containerd-gen2.txt
@@ -130,0 +131 @@ mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.35.1-windows-hpc-1
diff --git a/vhd_files/2022-containerd.txt b/vhd_files/2022-containerd.txt
index 5141ffe..b2be025 100644
--- a/vhd_files/2022-containerd.txt
+++ b/vhd_files/2022-containerd.txt
@@ -130,0 +131 @@ mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.35.1-windows-hpc-1
diff --git a/vhd_files/2025-gen2.txt b/vhd_files/2025-gen2.txt
index 8ce74bd..d8b5901 100644
--- a/vhd_files/2025-gen2.txt
+++ b/vhd_files/2025-gen2.txt
@@ -60,0 +61 @@ mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.35.1-windows-hpc-1
diff --git a/vhd_files/2025.txt b/vhd_files/2025.txt
index f1f0785..07766e1 100644
--- a/vhd_files/2025.txt
+++ b/vhd_files/2025.txt
@@ -60,0 +61 @@ mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.35.1-windows-hpc-1
diff --git a/vhd_files/23H2-gen2.txt b/vhd_files/23H2-gen2.txt
index ac3c0b7..0d6dd4e 100644
--- a/vhd_files/23H2-gen2.txt
+++ b/vhd_files/23H2-gen2.txt
@@ -80,0 +81 @@ mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.35.1-windows-hpc-1
diff --git a/vhd_files/23H2.txt b/vhd_files/23H2.txt
index 7467693..e21eb82 100644
--- a/vhd_files/23H2.txt
+++ b/vhd_files/23H2.txt
@@ -80,0 +81 @@ mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.35.1-windows-hpc-1 |
| }, | ||
| { | ||
| "renovateTag": "registry=https://mcr.microsoft.com, name=oss/v2/kubernetes/azure-cloud-node-manager", | ||
| "latestVersion": "v1.35.1-1" |
There was a problem hiding this comment.
shoudl we add previsou 1.35.0 ? or it was never released and AKS-RP uses 1.34 for me ?
| }, | ||
| { | ||
| "renovateTag": "registry=https://mcr.microsoft.com, name=oss/v2/kubernetes/azure-cloud-node-manager", | ||
| "latestVersion": "v1.35.1-windows-hpc-1" |
There was a problem hiding this comment.
this tagging format isn't compatible with Renovate version scheme, can't we use instead a more semver type of versions ?
There was a problem hiding this comment.
Could you please elaborate on the Renovate version scheme requirement? Dalec image tags currently follow the version-tagSuffix-revision format.
What this PR does / why we need it:
This PR adds v1.35.0 entry for cloud-node-manager.
Which issue(s) this PR fixes:
Fixes #