Fix pedestrian walk timer not resetting on state change#3
Open
thiagoralves wants to merge 1 commit into
Open
Conversation
thiagoralves
force-pushed
the
development
branch
from
52b06b8 to
feea7ad
Compare
thiagoralves
force-pushed
the
fix/pedestrian-timeout
branch
from
26a4ae6 to
57f0d95
Compare
thiagoralves
force-pushed
the
development
branch
from
feea7ad to
f785a61
Compare
thiagoralves
force-pushed
the
fix/pedestrian-timeout
branch
2 times, most recently
from
69ac048 to
64bfa3f
Compare
thiagoralves
force-pushed
the
development
branch
from
f785a61 to
5a5430a
Compare
thiagoralves
force-pushed
the
fix/pedestrian-timeout
branch
2 times, most recently
from
b2ffff1 to
64f4a8d
Compare
When traffic transitions away from RED while a pedestrian walk is active, the walk and flash timers were not being reset. This caused stale timer state to carry over into the next walk cycle, potentially shortening or skipping the walk phase entirely. Reset both walkTimer and flashTimer when cancelling a walk due to traffic state change.
thiagoralves
force-pushed
the
fix/pedestrian-timeout
branch
from
64f4a8d to
d4a5283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
walkTimerandflashTimerin the traffic state change cleanup blockTest plan